Thanks for driving this Ahmed. This change will benefit future and current sink implementations by giving the developer more flexibility. A good addition following configurable rate limiting strategies [1].
+1 (binding) Thanks, Danny [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-242%3A+Introduce+configurable+RateLimitingStrategy+for+Async+Sink On Sun, Mar 26, 2023 at 2:27 PM Ahmed Hamdy <hamdy10...@gmail.com> wrote: > Dear Flink developers, > > I want to move discussion on this FLIP[1] to voting. Discussion thread[2] > has been inactive for more than 2 months. Please feel free to add your > feedback below. > > The vote will be open for at least 72 > hours unless there is an objection or not enough votes. > > [1] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-284+%3A+Making+AsyncSinkWriter+Flush+triggers+adjustable > [2] https://lists.apache.org/thread/hmh2xoy34jm4r81txm3x1wv27d6vnpkw >
