+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PRs
On Thu, May 4, 2023 at 6:37 AM Leonard Xu <xbjt...@gmail.com> wrote: > +1 (binding) > > - built from source code succeeded > - verified signatures > - verified hashsums > - checked Github release tag > - checked release notes > - reviewed the web PR > - filed issue FLINK-31994[1] to update the copyright year, not a blocker > > Best, > Leonard > [1] https://issues.apache.org/jira/browse/FLINK-31994 > > > 2023年5月2日 下午8:48，Danny Cranmer <dannycran...@apache.org> 写道： > > > > +1 (binding) > > > > - Release notes look good > > - Source archive signature and checksums good > > - Verified there are no binaries in the source archive > > - Contents of Maven repo look good/match source build > > - Built from sourcepass > > - Tag is present in Github > > - Verified NOTICE files > > > > Observations > > - NOTICE file copyright still says 2021, not blocking but needs to be > > updated > > > > Thanks, > > Danny > > > > On Thu, Apr 20, 2023 at 5:02 PM Matthias Pohl > > <matthias.p...@aiven.io.invalid> wrote: > > > >> Thanks Martijn for driving the flink-shaded release. > >> > >> +1 (non-binding) > >> > >> * Downloaded artifact > >> * Verified SHA512 checksums > >> * GPG signatures Compared > >> * checkout with provided sources > >> * Verified pom file versions > >> * Went over NOTICE file/pom files changes once more without finding > >> anything suspicious > >> * build Flink 1.17.0 (which should have been probably rather master 8) ) > >> with flink-shaded 17.0 without issues > >> * run Flink session cluster using the binaries from the previously > >> mentioned build and deployed WordCount example job without issues > >> > >> On Thu, Apr 20, 2023 at 2:26 PM Martijn Visser < > martijnvis...@apache.org> > >> wrote: > >> > >>> Hi everyone, > >>> > >>> Please review and vote on the release candidate #1 for the version > 17.0, > >> as > >>> follows: > >>> [ ] +1, Approve the release > >>> [ ] -1, Do not approve the release (please provide specific comments) > >>> > >>> The complete staging area is available for your review, which includes: > >>> * JIRA release notes [1], > >>> * the official Apache source release to be deployed to dist.apache.org > >>> [2], > >>> which are signed with the key with fingerprint > >>> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > >>> * all artifacts to be deployed to the Maven Central Repository [4], > >>> * source code tag "release-17.0-rc1" [5], > >>> * website pull request listing the new release [6]. > >>> > >>> The vote will be open for at least 72 hours. It is adopted by majority > >>> approval, with at least 3 PMC affirmative votes. > >>> > >>> Thanks, > >>> Release Manager > >>> > >>> [1] > >>> > >>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352445 > >>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-17.0-rc1 > >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>> [4] > >>> > https://repository.apache.org/content/repositories/orgapacheflink-1628/ > >>> [5] > https://github.com/apache/flink-shaded/releases/tag/release-17.0-rc1 > >>> [6] https://github.com/apache/flink-web/pull/645 > >>> > >> > >
