+1 (binding)

Verified the following:
 - Source files, checksums, signatures
 - Helm chart points to correct tag, deployed with and without HA
 - Deployed stateful application, performed upgrade, deletion, logs contain
nothing unexpected
 - Checked release notes and maven repo contents

Confirmed that the deployment problem Tamir Sagi encountered was related to
a configuration error.

Cheers
Gyula

On Mon, May 15, 2023 at 9:17 AM Gyula Fóra <gyula.f...@gmail.com> wrote:

> Thank you Jim!
>
> Based on this workaround I would not necessarily consider this a blocker
> for the release but if we find any issues we can definitely include the fix
> in the next RC.
>
> @Tamir Sagi <tamir.s...@niceactimize.com> : It would be great to
> understand whether these issues are regressions compared to the 1.4.0
> operator version or not and whether they are specific to Flink 1.17. Until
> then I would not consider these blockers for the release.
>
> Cheers,
> Gyula
>
> On Mon, May 15, 2023 at 8:43 AM Jim Busche <jbus...@us.ibm.com> wrote:
>
>> Hi Gyula, Well, I don't understand this RBAC very well, but I got it to
>> work with a simple one-line change,
>>
>> adding the line "- flinkdeployments/finalizers" to the flink.apache.org
>> apiGroups section of the clusterrole like this:
>>
>>
>>
>> oc edit clusterrole flink-operator
>>
>>
>> - apiGroups:
>>
>>   - flink.apache.org
>>
>>   resources:
>>
>>   - flinkdeployments
>>
>>   - flinkdeployments/status
>>
>>   - flinkdeployments/finalizers
>>
>>   - flinksessionjobs
>>
>>   - flinksessionjobs/status
>>
>>   verbs:
>>
>>   - '*'
>>
>>
>>
>> Now the basic.yaml and the flinksessionjob examples deploy.
>> I'd like to try it with an OLM build tomorrow, and if it still looks
>> good, I'll make an issue and PR for it.
>> Thanks!  Jim
>>
>

Reply via email to