+1 (binding) - checked NOTICE and LICENSE - Verified signatures and hashes - Build and compile the source code locally - No unexpected binaries in the source release
Something can be improved: - NOTICE file can be updated to 2014-2023 from 2014-2022. Best, Jingsong On Tue, Jun 6, 2023 at 3:59 PM Jark Wu <imj...@gmail.com> wrote: > > +1 (binding) > > - Build and compile the source code locally: *OK* > - Verified signatures and hashes: *OK* > - Checked no missing artifacts in the staging area: *OK* > - Reviewed the website release PR: *OK* > > Best, > Jark > > On Thu, 1 Jun 2023 at 07:30, Jing Ge <j...@ververica.com.invalid> wrote: > > > +1(non-binding) > > > > - verified sign > > - verified hash > > - checked repos > > - checked tag. NIT: the tag link should be: > > https://github.com/apache/flink-connector-pulsar/releases/tag/v3.0.1-rc1 > > - reviewed PR. NIT: left a comment. > > > > Best regards, > > Jing > > > > On Wed, May 31, 2023 at 11:16 PM Neng Lu <nl...@apache.org> wrote: > > > > > +1 > > > > > > I verified > > > > > > + the release now can communicate with Pulsar using OAuth2 auth plugin > > > + build from source and run unit tests with JDK 17 on macOS M1Max > > > > > > > > > On Wed, May 31, 2023 at 4:24 AM Zili Chen <ti...@apache.org> wrote: > > > > > > > +1 > > > > > > > > I verified > > > > > > > > + LICENSE and NOTICE present > > > > + Checksum and GPG sign matches > > > > + No unexpected binaries in the source release > > > > + Build from source and run unit tests with JDK 17 on macOS M1 > > > > > > > > On 2023/05/25 16:18:51 Leonard Xu wrote: > > > > > Hey all, > > > > > > > > > > Please review and vote on the release candidate #1 for the version > > > 3.0.1 > > > > of the > > > > > Apache Flink Pulsar Connector as follows: > > > > > > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > JIRA release notes [1], > > > > > The official Apache source release to be deployed to dist.apache.org > > > > [2], which are signed with the key with > > > > fingerprint5B2F6608732389AEB67331F5B197E1F1108998AD [3], > > > > > All artifacts to be deployed to the Maven Central Repository [4], > > > > > Source code tag v3.0.1-rc1 [5], > > > > > Website pull request listing the new release [6]. > > > > > The vote will be open for at least 72 hours. It is adopted by > > majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > > Best, > > > > > Leonard > > > > > > > > > > [1] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352640 > > > > > [2] > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-pulsar-3.0.1-rc1/ > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [4] > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1641/ > > > > > [5] https://github.com/apache/flink-connector-pulsar/tree/v3.0.1-rc1 > > > > > [6] https://github.com/apache/flink-web/pull/655 > > > > > > > > > > > > > > > > > > >
