+1 Best, Junrui
Wencong Liu <liuwencle...@163.com> 于2023年7月24日周一 20:12写道： > Hi Timo, > > > Thanks for you reply. I think adding an empty OpenContext to keep the > signature is > reasonable. I'll modify the FLIP at a later time. > > > Best, > Wencong Liu > > > > > > > > > > > > > > > > > > At 2023-07-24 17:11:44, "Timo Walther" <twal...@apache.org> wrote: > >+1 > > > >But instead we should add a OpenContext there to keep the signature > >stable but still be able to add parameters. > > > >Regards, > >Timo > > > >On 21.07.23 12:24, Jing Ge wrote: > >> +1 > >> > >> On Fri, Jul 21, 2023 at 10:22 AM Yuxin Tan <tanyuxinw...@gmail.com> > wrote: > >> > >>> +1 > >>> > >>> Best, > >>> Yuxin > >>> > >>> > >>> Xintong Song <tonysong...@gmail.com> 于2023年7月21日周五 12:04写道： > >>> > >>>> +1 > >>>> > >>>> Best, > >>>> > >>>> Xintong > >>>> > >>>> > >>>> > >>>> On Fri, Jul 21, 2023 at 10:52 AM Wencong Liu <liuwencle...@163.com> > >>> wrote: > >>>> > >>>>> Hi devs, > >>>>> > >>>>> I would like to start a discussion on FLIP-344: Remove parameter in > >>>>> RichFunction#open [1]. > >>>>> > >>>>> The open() method in RichFunction requires a Configuration instance > as > >>> an > >>>>> argument, > >>>>> which is always passed as a new instance without any configuration > >>>>> parameters in > >>>>> AbstractUdfStreamOperator#open. Thus, it is unnecessary to include > this > >>>>> parameter > >>>>> in the open() method. > >>>>> As such I propose to remove the Configuration field from > >>>>> RichFunction#open(Configuration parameters). > >>>>> Looking forward to your feedback. > >>>>> [1] > >>>>> > >>>> > >>> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425231 > >>>>> Best regards, > >>>>> > >>>>> > >>>>> Wencong Liu > >>>> > >>> > >> >
