Looks good to me +1 From: Ryan Skraba <ryan.skr...@aiven.io.INVALID> Date: Wednesday, 25 October 2023 at 17:19 To: dev@flink.apache.org <dev@flink.apache.org> Subject: [EXTERNAL] [VOTE] Add JSON encoding to Avro serialization Hello!
I'm reviewing a new feature of another contributor (Dale Lane) on FLINK-33058 that adds JSON-encoding in addition to the binary Avro serialization format. He addressed my original objections that JSON encoding isn't _generally_ a best practice for Avro messages. The discussion is pretty well-captured in the JIRA and PR, but I wanted to give it a bit of visiblity and see if there were any strong opinions on the subject! Given the minor nature of this feature, I don't think it requires a FLIP. *TL;DR*: JSON-encoded Avro might not be ideal for production, but it has a place for small systems and especially setting up and testing before making the switch to binary-encoding. All my best, Ryan [Jira]: https://issues.apache.org/jira/browse/FLINK-33058 [PR]: https://github.com/apache/flink/pull/23395 Unless otherwise stated above: IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
