@David, thanks for the reminder, I will figure out the steps
I missed later and pay more attention in the future.

@Max, My key has already been added to KEYS.

@EveryOne Thank you everyone for testing this!

Closing the vote now, the results will be announced in a separate email.

Best,
Rui

On Thu, Oct 26, 2023 at 9:44 PM Maximilian Michels <m...@apache.org> wrote:

> +1 (binding)
>
> 1. Downloaded the archives, checksums, and signatures
> 2. Verified the signatures and checksums ( gpg --recv-keys
> B2D64016B940A7E0B9B72E0D7D0528B28037D8BC )
> 3. Extract and inspect the source code for binaries
> 4. Compiled and tested the source code via mvn verify
> 5. Verified license files / headers
> 6. Deployed helm chart to test cluster
> 7. Ran example job
> 8. Tested autoscaling without rescaling API
>
> @Rui Can you add your key to
> https://dist.apache.org/repos/dist/release/flink/KEYS ?
>
> -Max
>
> On Thu, Oct 26, 2023 at 1:53 PM Márton Balassi <balassi.mar...@gmail.com>
> wrote:
> >
> > Thank you, team. @David Radley: Not having Rui's key signed is not ideal,
> > but is acceptable for the release.
> >
> > +1 (binding)
> >
> > - Verified Helm repo works as expected, points to correct image tag,
> build,
> > version
> > - Verified basic examples + checked operator logs everything looks as
> > expected
> > - Verified hashes, signatures and source release contains no binaries
> > - Ran built-in tests, built jars + docker image from source successfully
> >
> > Best,
> > Marton
> >
> > On Thu, Oct 26, 2023 at 12:24 PM David Radley <david_rad...@uk.ibm.com>
> > wrote:
> >
> > > Hi,
> > > I downloaded the artifacts.
> > >
> > >   *   I did an install of the operator and ran the basic sample
> > >   *   I checked the checksums
> > >   *   Checked the GPG signatures
> > >   *   Ran the UI
> > >   *   Ran a Twistlock scan
> > >   *   I installed 1.6 then did a helm upgrade
> > >   *   I have not managed to do the source build and subsequent install
> yet.
> > > I wanted to check these 2 things are what you would expect:
> > >
> > >   1.  I followed link
> > >
> https://github.com/apache/flink-kubernetes-operator/pkgs/container/flink-kubernetes-operator/139454270?tag=51eeae1
> > > And notice that it does not have a description . Is this correct?
> > >
> > >   1.  I get this in the gpg verification . Is this ok?
> > >
> > >
> > > gpg --verify flink-kubernetes-operator-1.6.1-src.tgz.asc
> > >
> > > gpg: assuming signed data in 'flink-kubernetes-operator-1.6.1-src.tgz'
> > >
> > > gpg: Signature made Fri 20 Oct 2023 04:07:48 PDT
> > >
> > > gpg:                using RSA key
> B2D64016B940A7E0B9B72E0D7D0528B28037D8BC
> > >
> > > gpg: Good signature from "Rui Fan fan...@apache.org<mailto:
> > > fan...@apache.org>" [unknown]
> > >
> > > gpg: WARNING: This key is not certified with a trusted signature!
> > >
> > > gpg:          There is no indication that the signature belongs to the
> > > owner.
> > >
> > > Primary key fingerprint: B2D6 4016 B940 A7E0 B9B7  2E0D 7D05 28B2 8037
> D8BC
> > >
> > >
> > >
> > >
> > > Hi Everyone,
> > >
> > > Please review and vote on the release candidate #1 for the version
> 1.6.1 of
> > > Apache Flink Kubernetes Operator,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > **Release Overview**
> > >
> > > As an overview, the release consists of the following:
> > > a) Kubernetes Operator canonical source distribution (including the
> > > Dockerfile), to be deployed to the release repository at
> dist.apache.org
> > > b) Kubernetes Operator Helm Chart to be deployed to the release
> repository
> > > at dist.apache.org
> > > c) Maven artifacts to be deployed to the Maven Central Repository
> > > d) Docker image to be pushed to dockerhub
> > >
> > > **Staging Areas to Review**
> > >
> > > The staging areas containing the above mentioned artifacts are as
> follows,
> > > for your review:
> > > * All artifacts for a,b) can be found in the corresponding dev
> repository
> > > at dist.apache.org [1]
> > > * All artifacts for c) can be found at the Apache Nexus Repository [2]
> > > * The docker image for d) is staged on github [3]
> > >
> > > All artifacts are signed with the
> > > key B2D64016B940A7E0B9B72E0D7D0528B28037D8BC [4]
> > >
> > > Other links for your review:
> > > * source code tag "release-1.6.1-rc1" [5]
> > > * PR to update the website Downloads page to
> > > include Kubernetes Operator links [6]
> > > * PR to update the doc version of flink-kubernetes-operator[7]
> > >
> > > **Vote Duration**
> > >
> > > The voting time will run for at least 72 hours.
> > > It is adopted by majority approval, with at least 3 PMC affirmative
> votes.
> > >
> > > **Note on Verification**
> > >
> > > You can follow the basic verification guide here[8].
> > > Note that you don't need to verify everything yourself, but please make
> > > note of what you have tested together with your +- vote.
> > >
> > > [1]
> > >
> > >
> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.6.1-rc1/
> > > [2]
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1663/
> > > [3]
> > >
> > >
> https://github.com/apache/flink-kubernetes-operator/pkgs/container/flink-kubernetes-operator/139454270?tag=51eeae1
> > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [5]
> > >
> https://github.com/apache/flink-kubernetes-operator/tree/release-1.6.1-rc1
> > > [6] https://github.com/apache/flink-web/pull/690
> > > [7] https://github.com/apache/flink-kubernetes-operator/pull/687
> > > [8]
> > >
> > >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release
> > >
> > > Best,
> > > Rui
> > >
> > > Unless otherwise stated above:
> > >
> > > IBM United Kingdom Limited
> > > Registered in England and Wales with number 741598
> > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
> > >
>

Reply via email to