Hi, Leonard, jiabao Thanks for migrating the test classes.
I have noticed that many test classes (e.g., FlinkCalciteCatalogReaderTest) in flink-table (including flink-table-planner) have been updated to use AssertJ. However, their dependent test classes still utilize org.junit.Test or org.junit.Before, etc., whereas they should be using org.junit.jupiter.api.Test, etc. These classes are mostly from the issue FLINK-26582[1]. Maybe we need to fix these classes as well. [1] https://github.com/apache/flink/pull/19039 Best, Yuxin Jane Chan <qingyue....@gmail.com> 于2023年11月22日周三 15:32写道： > Thanks Leonard and Jiabao for your tremendous efforts in this regard! > > Best, > Jane > > On Wed, Nov 22, 2023 at 2:42 PM Leonard Xu <xbjt...@gmail.com> wrote: > > > Hi, all > > > > There are a lot of JUnit4 tests in flink-table-planner module, but now > > Jiabao and I have just migrated all tests to JUnit5 through > FLINK-29451[1]. > > > > Please use JUnit5 tests when submitting new PRs for flink-table-planner > > module. The opened PRs for flink-table-planner module need to rebase to > the > > latest master. > > > > Thanks Jiabao for the huge efforts. > > > > > > Best, > > Leonard > > > > [1]https://issues.apache.org/jira/browse/FLINK-29541 >
