Hi, Hmmm, it would have been good to mark the Jira ticket as a Blocker then for the JDBC connector. Since it's marked as Critical, it doesn't appear. It has also been open for multiple months, so it doesn't really feel like a Blocker. I'm +0 with including this fix, but then we should either get that in quickly or revert FLINK-16024, especially since this bug ticket has been open for multiple months. Right now, it means that we don't have a working JDBC connector for Flink 1.17 and Flink 1.18. That shouldn't be OK.
Thanks, Martijn On Fri, Jan 5, 2024 at 2:31 PM Sergey Nuyanzin <snuyan...@gmail.com> wrote: > > Thanks for driving this > > the thing which makes me thinking about -1 (not sure yet and that's why > asking here) is that there is FLINK-33365 [1] > mentioned as a blocker for JDBC connector release at [2] > Since the reason for that is FLINK-16024 [3] as also was explained in > comments for [1]. > > So should we wait for a fix of [1] or revert [3] for 3.1.x and continue > releasing 3.1.2? > > > [1] https://issues.apache.org/jira/browse/FLINK-33365 > [2] https://lists.apache.org/thread/sdkm5qshqozow9sljz6c0qjft6kg9cwc > > [3] https://issues.apache.org/jira/browse/FLINK-16024 > > On Fri, Jan 5, 2024 at 2:19 PM Martijn Visser <martijnvis...@apache.org> > wrote: > > > Hi everyone, > > Please review and vote on the release candidate #1 for the version > > 3.1.2, as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x. > > > > The complete staging area is available for your review, which includes: > > * JIRA release notes [1], > > * the official Apache source release to be deployed to dist.apache.org > > [2], which are signed with the key with fingerprint > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > > * all artifacts to be deployed to the Maven Central Repository [4], > > * source code tag v3.1.2-rc1 [5], > > * website pull request listing the new release [6]. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Release Manager > > > > [1] > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354088 > > [2] > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc1 > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > [4] > > https://repository.apache.org/content/repositories/orgapacheflink-1691/ > > [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc1 > > [6] https://github.com/apache/flink-web/pull/707 > > > > > -- > Best regards, > Sergey
