+1 (non-binding) - checked signature and checksum: OK - checkout copyright year in notice file: OK - diffed source distribution with tag, make sure there is no unexpected files: OK - build from source : OK - start a local cluster, played with jdbc connector: OK
weijie guo <guoweijieres...@gmail.com> 于2024年3月12日周二 16:55写道： > > +1 (non-binding) > > - Verified signature and checksum > - Verified source distribution does not contains binaries > - Build from source code and submit a word-count job successfully > > > Best regards, > > Weijie > > > Jane Chan <qingyue....@gmail.com> 于2024年3月12日周二 16:38写道： > > > +1 (non-binding) > > > > - Verify that the source distributions do not contain any binaries; > > - Build the source distribution to ensure all source files have Apache > > headers; > > - Verify checksum and GPG signatures; > > > > Best, > > Jane > > > > On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su <suxuanna...@gmail.com> wrote: > > > > > +1 (non-binding) > > > > > > - Verified signature and checksum > > > - Verified that source distribution does not contain binaries > > > - Built from source code successfully > > > - Reviewed the release announcement PR > > > > > > Best regards, > > > Xuannan > > > > > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan <ruanhang1...@gmail.com> > > wrote: > > > > > > > > +1 (non-binding) > > > > > > > > - Verified signatures and checksums > > > > - Verified that source does not contain binaries > > > > - Build source code successfully > > > > - Reviewed the release note and left a comment > > > > > > > > Best, > > > > Hang > > > > > > > > Feng Jin <jinfeng1...@gmail.com> 于2024年3月12日周二 11:23写道： > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified signatures and checksums > > > > > - Verified that source does not contain binaries > > > > > - Build source code successfully > > > > > - Run a simple sql query successfully > > > > > > > > > > Best, > > > > > Feng Jin > > > > > > > > > > > > > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu <ron9....@gmail.com> wrote: > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > quickly verified: > > > > > > - verified that source distribution does not contain binaries > > > > > > - verified checksums > > > > > > - built source code successfully > > > > > > > > > > > > > > > > > > Best, > > > > > > Ron > > > > > > > > > > > > Jeyhun Karimov <je.kari...@gmail.com> 于2024年3月12日周二 01:00写道： > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > - verified that source distribution does not contain binaries > > > > > > > - verified signatures and checksums > > > > > > > - built source code successfully > > > > > > > > > > > > > > Regards, > > > > > > > Jeyhun > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb < > > decordea...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > > > - verified signatures and checksums > > > > > > > > - ASF headers are present in all expected file > > > > > > > > - No unexpected binaries files found in the source > > > > > > > > - Build successful locally > > > > > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Bests, > > > > > > > > Samrat > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy < > > > hamdy10...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi Lincoln > > > > > > > > > +1 (non-binding) from me > > > > > > > > > > > > > > > > > > - Verified Checksums & Signatures > > > > > > > > > - Verified Source dists don't contain binaries > > > > > > > > > - Built source successfully > > > > > > > > > - reviewed web PR > > > > > > > > > > > > > > > > > > > > > > > > > > > Best Regards > > > > > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee < > > > lincoln.8...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hi Robin, > > > > > > > > > > > > > > > > > > > > Thanks for helping verifying the release note[1], > > FLINK-14879 > > > > > > should > > > > > > > > not > > > > > > > > > > have been included, after confirming this > > > > > > > > > > I moved all unresolved non-blocker issues left over from > > > 1.19.0 > > > > > to > > > > > > > > 1.20.0 > > > > > > > > > > and reconfigured the release note [1]. > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > Lincoln Lee > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353282 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Robin Moffatt <ro...@decodable.co.invalid> 于2024年3月11日周一 > > > > > 19:36写道： > > > > > > > > > > > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE > > > DATABASE` > > > > > > > > > > (FLINK-14879) > > > > > > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > > > > > > When I try these in 1.19 RC2 the behaviour is as in > > 1.18.1, > > > > > i.e. > > > > > > it > > > > > > > > is > > > > > > > > > > not > > > > > > > > > > > supported: > > > > > > > > > > > > > > > > > > > > > > ``` > > > > > > > > > > > [INFO] Execute statement succeed. > > > > > > > > > > > > > > > > > > > > > > Flink SQL> show catalogs; > > > > > > > > > > > +-----------------+ > > > > > > > > > > > | catalog name | > > > > > > > > > > > +-----------------+ > > > > > > > > > > > | c_new | > > > > > > > > > > > | default_catalog | > > > > > > > > > > > +-----------------+ > > > > > > > > > > > 2 rows in set > > > > > > > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: > > > Column > > > > > > > 'c_new' > > > > > > > > > not > > > > > > > > > > > found in any table > > > > > > > > > > > > > > > > > > > > > > Flink SQL> show databases; > > > > > > > > > > > +------------------+ > > > > > > > > > > > | database name | > > > > > > > > > > > +------------------+ > > > > > > > > > > > | default_database | > > > > > > > > > > > +------------------+ > > > > > > > > > > > 1 row in set > > > > > > > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: > > > Column > > > > > > > > > > > 'default_database' not found in > > > > > > > > > > > any table > > > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > > > > > Is this an error in the release notes, or my mistake in > > > > > > > interpreting > > > > > > > > > > them? > > > > > > > > > > > > > > > > > > > > > > thanks, Robin. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353282 > > > > > > > > > > > > > > > > > > > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee < > > > > > lincoln.8...@gmail.com > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > > > > > > > Please review and vote on the release candidate #2 for > > > the > > > > > > > version > > > > > > > > > > > 1.19.0, > > > > > > > > > > > > as follows: > > > > > > > > > > > > [ ] +1, Approve the release > > > > > > > > > > > > [ ] -1, Do not approve the release (please provide > > > specific > > > > > > > > comments) > > > > > > > > > > > > > > > > > > > > > > > > The complete staging area is available for your review, > > > which > > > > > > > > > includes: > > > > > > > > > > > > > > > > > > > > > > > > * JIRA release notes [1], and the pull request adding > > > release > > > > > > > note > > > > > > > > > for > > > > > > > > > > > > users [2] > > > > > > > > > > > > * the official Apache source release and binary > > > convenience > > > > > > > > releases > > > > > > > > > to > > > > > > > > > > > be > > > > > > > > > > > > deployed to dist.apache.org [3], which are signed with > > > the > > > > > key > > > > > > > > with > > > > > > > > > > > > fingerprint E57D30ABEE75CA06 [4], > > > > > > > > > > > > * all artifacts to be deployed to the Maven Central > > > > > Repository > > > > > > > [5], > > > > > > > > > > > > * source code tag "release-1.19.0-rc2" [6], > > > > > > > > > > > > * website pull request listing the new release and > > adding > > > > > > > > > announcement > > > > > > > > > > > blog > > > > > > > > > > > > post [7]. > > > > > > > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is > > > adopted by > > > > > > > > > majority > > > > > > > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353282 > > > > > > > > > > > > [2] https://github.com/apache/flink/pull/24394 > > > > > > > > > > > > [3] > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > > > > > > > > > > > > [4] > > > https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > > > > > [5] > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1709 > > > > > > > > > > > > [6] > > > > > > > > > > https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 > > > > > > > > > > > > [7] https://github.com/apache/flink-web/pull/721 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > > Yun, Jing, Martijn and Lincoln > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Best, Benchao Li
