Hi Qingsheng, I open a block issue[1] to add ci for NOTICE check and fix NOTICE file.
Best, Zhongqiang Gong [1] https://issues.apache.org/jira/browse/FLINK-35309 Qingsheng Ren <re...@apache.org> 于2024年5月8日周三 14:28写道： > Thanks everyone for your verification! > > I'll investigate the issue and prepare another RC once it is resolved. Much > appreciated to Jingsong! > > This release candidate is now canceled. > > Best, > Qingsheng > > On Wed, May 8, 2024 at 2:20 PM Jingsong Li <jingsongl...@gmail.com> wrote: > > > -1 > > > > Thanks Qingsheng for preparing this RC. > > > > If you bundle third-party dependencies (non Flink dependencies) in > > your published jar, you need to write them in the NOTICE file. > > > > I recommend adding a test using flink-ci-tools to verify if the NOTICE > > file is correct. Of course, you cannot rely too much on tools and > > still need to manually verify if it is correct. > > > > Best, > > Jingsong > > > > On Sat, May 4, 2024 at 7:45 PM Ahmed Hamdy <hamdy10...@gmail.com> wrote: > > > > > > Hi Qisheng, > > > > > > +1 (non-binding) > > > > > > - Verified checksums and hashes > > > - Verified signatures > > > - Verified github tag exists > > > - Verified no binaries in source > > > - build source > > > > > > > > > Best Regards > > > Ahmed Hamdy > > > > > > > > > On Fri, 3 May 2024 at 23:03, Jeyhun Karimov <je.kari...@gmail.com> > > wrote: > > > > > > > Hi Qinsheng, > > > > > > > > Thanks for driving the release. > > > > +1 (non-binding) > > > > > > > > - No binaries in source > > > > - Verified Signatures > > > > - Github tag exists > > > > - Build source > > > > > > > > Regards, > > > > Jeyhun > > > > > > > > On Thu, May 2, 2024 at 10:52 PM Muhammet Orazov > > > > <mor+fl...@morazow.com.invalid> wrote: > > > > > > > > > Hey Qingsheng, > > > > > > > > > > Thanks a lot! +1 (non-binding) > > > > > > > > > > - Checked sha512sum hash > > > > > - Checked GPG signature > > > > > - Reviewed release notes > > > > > - Reviewed GitHub web pr (added minor suggestions) > > > > > - Built the source with JDK 11 & 8 > > > > > - Checked that src doesn't contain binary files > > > > > > > > > > Best, > > > > > Muhammet > > > > > > > > > > On 2024-04-30 05:11, Qingsheng Ren wrote: > > > > > > Hi everyone, > > > > > > > > > > > > Please review and vote on the release candidate #1 for the > version > > > > > > 3.1.0 of > > > > > > Apache Flink CDC, as follows: > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > **Release Overview** > > > > > > > > > > > > As an overview, the release consists of the following: > > > > > > a) Flink CDC source release to be deployed to dist.apache.org > > > > > > b) Maven artifacts to be deployed to the Maven Central Repository > > > > > > > > > > > > **Staging Areas to Review** > > > > > > > > > > > > The staging areas containing the above mentioned artifacts are as > > > > > > follows, > > > > > > for your review: > > > > > > * All artifacts for a) can be found in the corresponding dev > > repository > > > > > > at > > > > > > dist.apache.org [1], which are signed with the key with > > fingerprint > > > > > > A1BD477F79D036D2C30CA7DBCA8AEEC2F6EB040B [2] > > > > > > * All artifacts for b) can be found at the Apache Nexus > Repository > > [3] > > > > > > > > > > > > Other links for your review: > > > > > > * JIRA release notes [4] > > > > > > * Source code tag "release-3.1.0-rc1" with commit hash > > > > > > 63b42cb937d481f558209ab3c8547959cf039643 [5] > > > > > > * PR for release announcement blog post of Flink CDC 3.1.0 in > > flink-web > > > > > > [6] > > > > > > > > > > > > **Vote Duration** > > > > > > > > > > > > The voting time will run for at least 72 hours, adopted by > majority > > > > > > approval with at least 3 PMC affirmative votes. > > > > > > > > > > > > Thanks, > > > > > > Qingsheng Ren > > > > > > > > > > > > [1] > > https://dist.apache.org/repos/dist/dev/flink/flink-cdc-3.1.0-rc1/ > > > > > > [2] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > [3] > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1731 > > > > > > [4] > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354387 > > > > > > [5] > > https://github.com/apache/flink-cdc/releases/tag/release-3.1.0-rc1 > > > > > > [6] https://github.com/apache/flink-web/pull/739 > > > > > > > > > > > >
