Mingliang Liu created FLINK-35472:
-------------------------------------
Summary: Improve tests for Elasticsearch 8 connector
Key: FLINK-35472
URL: https://issues.apache.org/jira/browse/FLINK-35472
Project: Flink
Issue Type: Improvement
Components: Connectors / ElasticSearch, Tests
Reporter: Mingliang Liu
Per discussion in [this
PR|https://github.com/apache/flink-connector-elasticsearch/pull/104], it makes
the tests more reusable if we use parameterized tests. It requires some changes
of the existing tests, which includes:
# Make base test class parameterized with secure parameter. As JUnit 5 has
limited support for parameterized tests with inheritance, we can use the
{{ParameterizedTestExtension}} introduced in Flink, see this doc
# Manage the test container lifecycle instead of using the managed annotation
{{@Testcontainers}} and {{@Container}} so that the test containers can be used
as a singleton for all tests in the suite
# Create and use common methods in the base class that concrete test classes
can be mostly parameter-agnostic
This JIRA intends to not change any logic or functionality. Instead it focuses
on tests refactoring for more reusable tests and future proof.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
