> -1 (non-binding)
> blocked by https://issues.apache.org/jira/browse/FLINK-35496.


I just replied in https://issues.apache.org/jira/browse/FLINK-35496 
<https://issues.apache.org/jira/browse/FLINK-35496>, I think the API annotation 
understanding is incorrect in this case, hope to see your comments

Best,
Leonard




> Best, 
> Yuepeng Pan
> 
> 
> On 2024/05/22 12:13:51 Leonard Xu wrote:
>> +1 (binding)
>> 
>> - verified signatures
>> - verified hashsums
>> - built from source code with java 1.8 succeeded
>> - checked Github release tag 
>> - checked release notes
>> - reviewed the web PR
>> 
>> Best,
>> Leonard
>> 
>>> 2024年4月21日 下午9:42,Hang Ruan <ruanhang1...@gmail.com> 写道:
>>> 
>>> +1 (non-binding)
>>> 
>>> - Validated checksum hash
>>> - Verified signature
>>> - Verified that no binaries exist in the source archive
>>> - Build the source with Maven and jdk8
>>> - Verified web PR
>>> - Check that the jar is built by jdk8
>>> 
>>> Best,
>>> Hang
>>> 
>>> Ahmed Hamdy <hamdy10...@gmail.com> 于2024年4月18日周四 21:37写道:
>>> 
>>>> +1 (non-binding)
>>>> 
>>>> - Verified Checksums and hashes
>>>> - Verified Signatures
>>>> - No binaries in source
>>>> - Build source
>>>> - Github tag exists
>>>> - Reviewed Web PR
>>>> 
>>>> 
>>>> Best Regards
>>>> Ahmed Hamdy
>>>> 
>>>> 
>>>> On Thu, 18 Apr 2024 at 11:22, Danny Cranmer <dannycran...@apache.org>
>>>> wrote:
>>>> 
>>>>> Sorry for typos:
>>>>> 
>>>>>> Please review and vote on the release candidate #1 for the version
>>>> 3.2.0,
>>>>> as follows:
>>>>> Should be "release candidate #2"
>>>>> 
>>>>>> * source code tag v3.2.0-rc1 [5],
>>>>> Should be "source code tag v3.2.0-rc2"
>>>>> 
>>>>> Thanks,
>>>>> Danny
>>>>> 
>>>>> On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer <dannycran...@apache.org>
>>>>> wrote:
>>>>> 
>>>>>> Hi everyone,
>>>>>> 
>>>>>> Please review and vote on the release candidate #1 for the version
>>>> 3.2.0,
>>>>>> as follows:
>>>>>> [ ] +1, Approve the release
>>>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>>> 
>>>>>> This release supports Flink 1.18 and 1.19.
>>>>>> 
>>>>>> The complete staging area is available for your review, which includes:
>>>>>> * JIRA release notes [1],
>>>>>> * the official Apache source release to be deployed to dist.apache.org
>>>>>> [2], which are signed with the key with fingerprint 125FD8DB [3],
>>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>>>> * source code tag v3.2.0-rc1 [5],
>>>>>> * website pull request listing the new release [6].
>>>>>> * CI run of tag [7].
>>>>>> 
>>>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>>>> approval, with at least 3 PMC affirmative votes.
>>>>>> 
>>>>>> Thanks,
>>>>>> Danny
>>>>>> 
>>>>>> [1]
>>>>>> 
>>>>> 
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353143
>>>>>> [2]
>>>>>> 
>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>>>> [4]
>>>>>> 
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1718/
>>>>>> [5]
>>>>> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
>>>>>> [6] https://github.com/apache/flink-web/pull/734
>>>>>> [7]
>>>>> https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
>>>>>> 
>>>>> 
>>>> 
>> 
>> 

Reply via email to