Hi Sergey, FYI we also meet the regression of stringRead or stringWrite when upgrading the JMH[1]. I guess it is caused by JIT. I'd suggest accepting it if JIT is so sensitive to 'unrelated' change in codebase, since this probably won't be a problem in production environment.
I recommend we do not overemphasize these results. How about going ahead with the upgrade first and testing the performance, then we can discuss if there is indeed a concern. [1] https://issues.apache.org/jira/browse/FLINK-35629 Best, Zakelly On Thu, Jun 27, 2024 at 6:21 PM Sergey Nuyanzin <snuyan...@gmail.com> wrote: > Thanks for starting this discussion Dawid > > In general I'm +1 for the release > > IIRC there is one blocker for flink-shaded[1] which was the reason of > downgrading it from 18 to 17[2] > > I would suggest to resolve it first > > [1] https://issues.apache.org/jira/browse/FLINK-34234 > [2] https://issues.apache.org/jira/browse/FLINK-34148 > > On Thu, Jun 27, 2024 at 11:42 AM Dawid Wysakowicz > <dwysakow...@apache.org> wrote: > > > > Hi, > > I'd like to propose releasing flink-shaded 19.0. I suggest it has a very > > limited scope and include just shading of > com.jayway.jsonpath:json-path[1] > > > > This would let us fix FLINK-35696[2] > > > > If there are no objections, I'd prepare a release. > > > > [1] > > > https://github.com/apache/flink-shaded/commit/b23e1a811fcacbc5f53993297304131246bb5d04 > > [2] https://issues.apache.org/jira/browse/FLINK-35696 > > > > Best, > > Dawid > > > > -- > Best regards, > Sergey >
