Thanks Hong, > 1/ New connectors (SQS sink, DynamoDB Streams source). We are also adding more functionality to the KDS source based on FLIP-27 interfaces.
These would not warrant a v5.x, but the breaking change to the DynamicTableSource (2) does. Since we do not have state compatibility between the new and legacy source we need to make this clear in the docs. I do not see a task for this. I will continue to review the release artifacts based on the agreement that we update the docs before we finalize the release. --- -1 (binding) For the actual release checks, unfortunately I found an issue. flink-sql-connector-dynamodb (and others) NOTICE files are missing dependencies that are bundled: < software.amazon.awssdk:checksums-spi:2.26.19 < software.amazon.awssdk:checksums:2.26.19 < software.amazon.awssdk:http-auth-aws:2.26.19 < software.amazon.awssdk:http-auth-spi:2.26.19 < software.amazon.awssdk:http-auth:2.26.19 < software.amazon.awssdk:identity-spi:2.26.19 < software.amazon.awssdk:retries-spi:2.26.19 < software.amazon.awssdk:retries:2.26.19 We will need to check other NOTICE files, update them and create RC3. Thanks, Danny On Tue, Nov 5, 2024 at 6:34 PM Hong Liang <hlteo...@gmail.com> wrote: > Thanks for the question Danny. We are making the major version bump from 4 > to 5 because of the following changes: > > 1/ New connectors (SQS sink, DynamoDB Streams source). We are also adding > more functionality to the KDS source based on FLIP-27 interfaces. > 2/ Breaking changes to the KDS source via Table and SQL API for the > "flink-kinesis-connector" artifact (the old artifact). > > We are taking step (2) because the new KDS source has different > configuration options compared to the old KDS source. > > Regards, > Hong > > On Tue, Nov 5, 2024 at 6:23 PM Danny Cranmer <dannycran...@apache.org> > wrote: > > > Thanks for driving this release Hong. I cannot find the discussion > thread, > > and was wondering what the justification is for a major release this > time? > > What are we breaking? > > > > I will take a look at the release artifacts tomorrow. > > > > Thanks, > > Danny > > > > On Tue, 5 Nov 2024, 08:06 Yanquan Lv, <decq12y...@gmail.com> wrote: > > > > > +1 (non-binding) > > > > > > Thanks for Hong’s explanation. > > > I'm just making sure we haven't missed any previous discussions. > > > > > > > > > > 2024年11月5日 15:51，Hong Liang <h...@apache.org> 写道： > > > > > > > > Hi Yanquan, > > > > Thanks for checking in - I did not send an email about RC1, because I > > > built > > > > it, then realized we wanted to include an additional PR. I tried > > reusing > > > > the same rc1 tag, but it interfered with the release scripts > (couldn't > > > > upload to dist.apache.org, due to existing directory.) > > > > > > > > Instead of messing around with the release scripts, I decided to just > > > > create a RC2 instead. Hope that explains the situation. > > > > > > > > > > > > Hong > > > > > > > > On Tue, Nov 5, 2024 at 7:25 AM Yanquan Lv <decq12y...@gmail.com> > > wrote: > > > > > > > >> I've checked: > > > >> - Review JIRA release notes > > > >> - Verify hashes and verify signatures > > > >> - Build success from source with JDK11 & maven3.8.6 > > > >> - Source code artifacts matching the current release > > > >> > > > >> I’ve searched the mail list and could not find the vote about > > > >> flink-connector-aws v5.0.0 release candidate #1, so I’m wondering > Why > > > is it > > > >> release candidate #1 this time, or am I missing something? > > > >> > > > >> > > > >>> 2024年11月5日 07:00，Hong Liang <h...@apache.org> 写道： > > > >>> > > > >>> Hi everyone, > > > >>> Please review and vote on release candidate #2 for > > flink-connector-aws > > > >>> v5.0.0, as follows: > > > >>> [ ] +1, Approve the release > > > >>> [ ] -1, Do not approve the release (please provide specific > comments) > > > >>> > > > >>> This version supports Flink 1.19 and 1.20. > > > >>> > > > >>> The complete staging area is available for your review, which > > includes: > > > >>> * JIRA release notes [1], > > > >>> * the official Apache source release to be deployed to > > dist.apache.org > > > >> [2], > > > >>> which are signed with the key with fingerprint B78A5EA1 [3], > > > >>> * all artifacts to be deployed to the Maven Central Repository [4], > > > >>> * source code tag v5.0.0-rc2 [5], > > > >>> * website pull request listing the new release [6]. > > > >>> * CI build of the tag [7]. > > > >>> > > > >>> The vote will be open for at least 72 hours. It is adopted by > > majority > > > >>> approval, with at least 3 PMC affirmative votes. > > > >>> > > > >>> Thanks, > > > >>> Hong > > > >>> > > > >>> [1] > > > >>> > > > >> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12355257 > > > >>> [2] > > > >>> > > > >> > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-aws-5.0.0-rc2/ > > > >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >>> [4] > > > >> > > https://repository.apache.org/content/repositories/orgapacheflink-1766/ > > > >>> [5] > > > >> > https://github.com/apache/flink-connector-aws/releases/tag/v5.0.0-rc2 > > > >>> [6] https://github.com/apache/flink-web/pull/760 > > > >>> [7] > > > >> > > https://github.com/apache/flink-connector-aws/actions/runs/11673914158 > > > >> > > > >> > > > > > > > > >
