Thanks for the thorough verification Danny! > - I note that the AWS SDK version differs between flink-connector- prometheus [1] and flink-connector-aws [2]. This is probably ok, but not ideal. We should find a strategy to align this in the future to avoid dependency issues.
Thanks for the comment. Users can override the dependency using "dependencyManagement" if needed. > - NOTICE file looks ok, besides has 2023 in copyright, not blocking but please update [3] Good spot. Have updated. > - I note that we are bundling source code [4] which appears to be from protobuf [5] which is BSD license and acceptable to bundle [6]. However I would prefer if we delete it, but I do not think it is mandatory. Do we actually need this in the source? We do not strictly need it. I will remove them to sidestep any complexities with licensing. Regards, Hong On Wed, Nov 6, 2024 at 2:22 PM Danny Cranmer <dannycran...@apache.org> wrote: > Thanks for driving this Hong (and Lorenzo), nice to see the new > connector launching. > > +1 binding > > - I note that the AWS SDK version differs between > flink-connector-prometheus [1] and flink-connector-aws [2]. This is > probably ok, but not ideal. We should find a strategy to align this in the > future to avoid dependency issues. > - The release notes look good > - Signatures and checksums match on source archive > - There are no binaries in the source archive > - Verified CI build passes > - Tag exists in the code base > - Approved web PR > - Verified all applicable source files have Apache copyright heading > - NOTICE file looks ok, besides has 2023 in copyright, not blocking but > please update [3] > - Contents of the Maven repo look good > - Signatures and checksums match on binaries > - I note that we are bundling source code [4] which appears to be from > protobuf [5] which is BSD license and acceptable to bundle [6]. However I > would prefer if we delete it, but I do not think it is mandatory. Do we > actually need this in the source? > > Thanks, > Danny > > [1] > > https://github.com/apache/flink-connector-prometheus/blob/v1.0.0-rc1/pom.xml#L62 > [2] > https://github.com/apache/flink-connector-aws/blob/v5.0.0-rc2/pom.xml#L57 > [3] > https://github.com/apache/flink-connector-prometheus/blob/main/NOTICE#L2 > [4] > > https://github.com/apache/flink-connector-prometheus/blob/v1.0.0-rc1/flink-connector-prometheus/src/main/proto/gogoproto/gogo.proto > [5] https://github.com/gogo/protobuf/blob/master/gogoproto/gogo.proto > [6] https://www.apache.org/legal/resolved.html#category-a > > On Tue, Nov 5, 2024 at 9:23 AM Lorenzo Nicora <lorenzo.nic...@gmail.com> > wrote: > > > +1 (non binding) > > > > - verified checksums > > - run an e2e application using the 1.0.0-1.20 artifacts, (including > Amazon > > Managed Prometheus request signer) > > > > Best regards > > Lorenzo > > > > > > On Tue, 5 Nov 2024 at 07:37, Xintong Song <tonysong...@gmail.com> wrote: > > > > > +1 (binding) > > > > > > - verified signatures and checksum > > > - built from source > > > - reviewed web PR > > > > > > Best, > > > > > > Xintong > > > > > > > > > > > > On Tue, Nov 5, 2024 at 2:04 PM weijie guo <guoweijieres...@gmail.com> > > > wrote: > > > > > > > +1 (binding) > > > > > > > > - verified signatures > > > > - verified hashsums > > > > - checked github release tag > > > > - checked release notes > > > > - reviewed the web PR > > > > - build from source > > > > > > > > Best regards, > > > > > > > > Weijie > > > > > > > > > > > > Hong Liang <hlteo...@gmail.com> 于2024年11月5日周二 07:28写道： > > > > > > > > > Hi everyone, > > > > > Please review and vote on release candidate #1 for > > > > > flink-connector-prometheus v1.0.0, as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific > comments) > > > > > > > > > > This version supports Flink 1.19 and 1.20. > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > * JIRA release notes [1], > > > > > * the official Apache source release to be deployed to > > dist.apache.org > > > > > [2], > > > > > which are signed with the key with fingerprint B78A5EA1 [3], > > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > > * source code tag v1.0.0-rc1 [5], > > > > > * website pull request listing the new release [6]. > > > > > * CI build of the tag [7]. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > Thanks, > > > > > Hong > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353666 > > > > > [2] > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-prometheus-1.0.0-rc1 > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [4] > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1765 > > > > > [5] > > > > > > > > > > > > > > > > > > > > https://github.com/apache/flink-connector-prometheus/releases/tag/v1.0.0-rc1 > > > > > [6] https://github.com/apache/flink-web/pull/761 > > > > > [7] > > > > > > > > > > > > > > > > > > > > https://github.com/apache/flink-connector-prometheus/actions/runs/11553554874 > > > > > > > > > > > > > > >
