Since there are no objections I'll proceed with a vote. Best, Dawid On Wed, 15 Jan 2025 at 17:30, Timo Walther <twal...@apache.org> wrote:
> Thanks for the update Dawid. > > From my point of view, the FLIP is ready for voting. Unless somebody > else has any objections? > > Cheers, > Timo > > > On 15.01.25 10:20, Dawid Wysakowicz wrote: > > Sure, I updated the FLIP > > > > > > On Mon, 13 Jan 2025 at 15:20, Timo Walther <twal...@apache.org> wrote: > > > >> Hi Dawid, > >> > >> thanks for proposing this FLIP. It nicely completes the serialization > >> effort started with FLIP-393. I know naming is difficult, but could we > >> shorten and simplify the signatures further? > >> > >> My suggestion would be: > >> OperationSerializationContext -> SqlSerializationContext > >> ExpressionSerializationContext -> SqlSerializationContext > >> > >> > >> Given that we want to expose this via EnvironmentSettings, it should > >> have an easy to understand name. `Operations` are rather internal > >> classes which is why `Sql` might be a better fit. > >> > >> Regards, > >> Timo > >> > >> On 08.01.25 16:27, Dawid Wysakowicz wrote: > >>> Hi all, > >>> I'd like to start a discussion on adding a context to Operation and > >>> Expression SQL serialization stack to allow for serializing more > >> expression > >>> that require custom handling, such as inline functions. Please see[1] > for > >>> details. > >>> > >>> Looking forward to hearing from you. > >>> Best, > >>> Dawid > >>> [1] https://cwiki.apache.org/confluence/x/NIogF > >>> > >> > >> > > > >
