Hi Dawid.
Big +1 for this FLIP. After reading through it, I have a few questions and
would appreciate your responses:
1. IIUC, we only need to provide additional information in the
`FlinkChangelogModeInferenceProgram` to enable the
inference program to determine whether it is safe to remove
`ChangelogNormalize`. My first instinct is that we need to
know if all subsequent output-side nodes consuming Upsert Keys include the
Upsert Keys provided by the input-side operator (source).
If this condition is met, we can safely eliminate `ChangelogNormalize`.
Perhaps, I have missed some important points, so please feel
free to correct me if necessary.
2. The introduction of `supportsDeleteByKey` in ChangelogMode seems to exist
solely as auxiliary information for the
`FlinkChangelogModeInferenceProgram`. If that's the case, it doesn't seem
necessary to expose it in the public API, does it?
3. If the purpose of introducing `supportsDeleteByKey` in ChangelogMode is to
facilitate support for `#fromChangelogStream`
and `#toChangelogStream`, it appears that `supportsDeleteByKey` might overlap
with ChangelogMode#kinds and Schema#PK
to some extent, right?
4. Regarding supportsDeleteByKey, as part of a complete ChangelogMode entity,
should we also store the specific key information?
--
Best！
Xuyang
在 2025-02-28 04:27:19，"Martijn Visser" <martijnvis...@apache.org> 写道：
>Hi Dawid,
>
>Thanks for the FLIP, looks like a good improvement for me that will bring a
>lot of benefits. +1
>
>Best regards,
>
>Martijn
>
>On Tue, Feb 25, 2025 at 6:51 AM Sergey Nuyanzin <snuyan...@gmail.com> wrote:
>
>> +1 for such improvement
>>
>> On Mon, Feb 24, 2025 at 12:01 PM Dawid Wysakowicz
>> <wysakowicz.da...@gmail.com> wrote:
>> >
>> > Hi everyone,
>> >
>> > I would like to initiate a discussion for the FLIP-510[1] below, which
>> aims
>> > on optimising certain use cases in SQL which at the moment add
>> > ChangelogNormalize, but don't necessarily need to do it.
>> >
>> > Looking forward to hearing from you.
>> >
>> > [1] https://cwiki.apache.org/confluence/x/7o5EF
>>
>>
>>
>> --
>> Best regards,
>> Sergey
>>
