Hi Hao, Thanks for the FLIP! It provides a clearer guideline for developers to implement model functions.
One minor comment: it might be better to change the configuration api_key to apikey, which corresponds to GlobalConfiguration.SENSITIVE_KEYS. Otherwise users’ secrets might be exposed in logs and cause security risks. Best, Yunfeng > 2025年4月29日 07:22，Hao Li <h...@confluent.io.INVALID> 写道： > > Hi All, > > I would like to start a discussion about FLIP-525 [1]: Model ML_PREDICT, > ML_EVALUATE Implementation Design. This FLIP is co-authored with Shengkai > Fang. > > This FLIP is a follow up of FLIP-437 [2] to propose the implementation > design for ML_PREDICT and ML_EVALUATE function which were introduced in > FLIP-437. > > For more details, see FLIP-525 [1]. Looking forward to your feedback. > > > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-525%3A+Model+ML_PREDICT%2C+ML_EVALUATE+Implementation+Design > [2] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-437%3A+Support+ML+Models+in+Flink+SQL > > > Thanks, > Hao
