Hi all,
I have been reviewing a lot of PRs over the last few months. I like to share my
thoughts on a PR and prefix stylistic or trivial changes it with a nit:. I was
thinking that a comment starting with nit: is to draw the authors attention to
an idea or style change, which they could take or not – but is not a blocker to
merge.
I wonder if we should formally document in our process that this is what review
comments starting with nit: mean. I am happy to make this change to the wiki,
if there is agreement.
I am suggesting this in the spirit of:
* all respectful comments should be encouraged from all parts of the
community to encourage open communication.
* there is a clear distinction between review feedback that is expected to
be responded to in some way, and feedback that is a suggestion that can be
ignored or taken on at the authors discretion.
WDYT?
Kind regards, David.
Unless otherwise stated above:
IBM United Kingdom Limited
Registered in England and Wales with number 741598
Registered office: Building C, IBM Hursley Office, Hursley Park Road,
Winchester, Hampshire SO21 2JN
