Hi Dawid, Thanks for the FLIP. +1 to support options for functions as well.
I have one question: Do you want to update `createTemporarySystemFunction` in `TableEnvironment` to support `FunctionDescriptor` as well? Thanks, Hao On Tue, Jul 29, 2025 at 10:33 AM Yash Anand <yashanand.0...@gmail.com> wrote: > Hi Dawid, > > Thank you for initiating this FLIP, looks like a useful addition +1 for the > FLIP. > > I have just one question, will the option keys be limited to some > predefined values or it could be any key user wants to add as metadata? > Like if the user wants to add a description for each argument? > > On Tue, Jul 29, 2025 at 7:09 AM Timo Walther <twal...@apache.org> wrote: > > > Maybe not in the first version but eventually nothing in the design > > blocks us for supporting this. The SecretStore would need to be > > available in the FunctionDefinitionFactory for this. > > > > Cheers, > > Timo > > > > On 29.07.25 15:08, Ryan van Huuksloot wrote: > > > Overall the FLIP looks good to me. > > > > > > Would the properties support the SecretStore proposed in FLIP-529? > > > > > > Otherwise, +1, thanks! > > > > > > Ryan van Huuksloot > > > Staff Engineer, Infrastructure | Streaming Platform > > > [image: Shopify] > > > < > https://www.shopify.com/?utm_medium=salessignatures&utm_source=hs_email > > > > > > > > > > > > On Tue, Jul 29, 2025 at 4:19 AM Jacky Lau <liuyong...@gmail.com> > wrote: > > > > > >> Thanks for initiating this! > > >> > > >> +1 for this proposal. > > >> > > >> Sergey Nuyanzin <snuyan...@gmail.com> 于2025年7月29日周二 15:34写道： > > >> > > >>> Thanks for driving this Dawid. > > >>> > > >>> looks reasonable to me > > >>> > > >>> On Mon, Jul 28, 2025 at 5:03 PM Ramin Gharib <ramingha...@gmail.com> > > >>> wrote: > > >>>> > > >>>> Hello Dawid, > > >>>> > > >>>> Thanks for initiating this! The FLIP looks well-written. > > >>>> The WITH clause brings consistency to existing syntax. > > >>>> > > >>>> +1 for this proposal. > > >>>> > > >>>> On Mon, Jul 28, 2025 at 3:33 PM Dawid Wysakowicz < > > >> dwysakow...@apache.org > > >>>> > > >>>> wrote: > > >>>> > > >>>>> Hi, > > >>>>> I'd like to start a discussion of FLIP-539: Support WITH Clause in > > >>> CREATE > > >>>>> FUNCTION Statement in Flink SQL [1]. > > >>>>> > > >>>>> The existing CREATE FUNCTION statement in Flink SQL allows users > to > > >>>>> register user-defined functions (UDFs) by specifying the class name > > >>> and the > > >>>>> artifact (JAR) containing the implementation. While this design > > >> covers > > >>>>> common use cases, it lacks a declarative mechanism for associating > > >>>>> arbitrary properties or metadata with the function at creation > time. > > >>>>> > > >>>>> Other Flink SQL objects—such as tables—support a WITH clause for > > >>>>> specifying options in a key-value fashion, improving consistency, > > >>>>> discoverability, and extensibility. > > >>>>> Looking forward to comments and suggestions for improvements! > > >>>>> > > >>>>> Best, > > >>>>> Dawid > > >>>>> > > >>>>> [1] https://cwiki.apache.org/confluence/x/sg9JFg > > >>>>> > > >>> > > >>> > > >>> > > >>> -- > > >>> Best regards, > > >>> Sergey > > >>> > > >> > > > > > > > >
