+1, we built and tested the connector. Working fine! Thanks!
On 2025/07/21 07:22:31 Yanquan Lv wrote: > +1 (non-binding) > I checked: > - Review JIRA release notes > - Verify hashes and verify signatures > - Build success from source with JDK8 & maven3.8.6 > - Source code artifacts matching the current release > - Read the announcement blog and LGTM > > Best， > Yanquan > > Daren Wong <da...@gmail.com> 于2025年7月7日周一 18:41写道： > > > +1 (non-binding) > > > > - Built and tested all AWS Connectors' Source and Sink > > (TableAPI/SQL/Datastream): > > - Connectors tested are: Kinesis Source and Sink, Firehose Sink, > > DynamoDB Streams Source, DynamoDB Sink, SQS Sink > > - Deployed local flink cluster and ran example test application > > for each connectors on it > > - Full Test Results attached in > > https://drive.google.com/drive/folders/1wBMoT8F-AnFF0ANj_Oa42xXKkk3FdQA0?usp=sharing > > - Checked release notes > > - Checked source archive including (NOTICE, LICENSE, checksum, does not > > contain binary) > > - Checked source archive is signed with *125FD8DB > > - Checked that all poms point to version 5.1.0-1.20 > > - Checked that pom key is signed with *B78A5EA1* > > > > Regards, > > Daren > > > > > On 7 Jul 2025, at 18:19, Daren Wong <da...@gmail.com> wrote: > > > > > > Thanks Keith for catching this, I have validated what you said are > > correct as follows: > > > > > > - The source archive is signed with 125FD8DB > > > > > > ``` > > > (base) darenwkt Downloads % gpg --verify > > flink-connector-aws-5.1.0-src.tgz.asc flink-connector-aws-5.1.0-src.tgz > > > gpg: Signature made Fri 27 Jun 03:50:15 2025 +08 > > > gpg: using RSA key > > 0F79F2AFB2351BC29678544591F9C1EC125FD8DB > > > ``` > > > > > > - The pom is signed with B78A5EA1 > > > ``` > > > (base) darenwkt Downloads % gpg --verify > > flink-connector-aws-5.1.0-1.20.pom.asc flink-connector-aws-5.1.0-1.20.pom > > > gpg: Signature made Fri 27 Jun 00:40:56 2025 +08 > > > gpg: using RSA key > > 6378E37EB3AAEA188B9CB0D396C2914BB78A5EA1 > > > ``` > > > > > > Regards, > > > Daren > > > > > > > > >> On 28 Jun 2025, at 00:22, Keith Lee <le...@gmail.com> > > wrote: > > >> > > >> Hey Daren > > >> > > >> Similar question here are we are expecting the source release to be > > signed > > >> with *125FD8DB *instead of *B78A5EA1*? The pom is however signed with > > >> *B78A5EA1.* > > >> > > >> Providing notes on what I've checked: > > >> > > >> 1. Checked release notes > > >> 2. Checked source archive check sum > > >> 3. Checked source archive does not contain binary > > >> 4. Source archive is signed with *125FD8DB *instead of B78A5EA1 > > >> 5. Checked that all poms point to version 5.1.0-1.20 > > >> 6. Checked that pom key is signed with *B78A5EA1* > > >> > > >> Best regards > > >> Keith Lee > > >> > > >> > > >> On Fri, Jun 27, 2025 at 4:44 PM Keith Lee <le...@gmail.com> > > >> wrote: > > >> > > >>> +1, thank you Daren, Hong and Danny! > > >>> > > >>> Best regards > > >>> Keith Lee > > >>> > > >>> > > >>> On Fri, Jun 27, 2025 at 2:22 PM Daren Wong <da...@gmail.com> > > wrote: > > >>> > > >>>> Hi everyone, > > >>>> Please review and vote on release candidate #1 for flink-connector-aws > > >>>> v5.1.0, as follows: > > >>>> [ ] +1, Approve the release > > >>>> [ ] -1, Do not approve the release (please provide specific comments) > > >>>> > > >>>> > > >>>> The complete staging area is available for your review, which > > includes: > > >>>> * JIRA release notes [1], > > >>>> * the official Apache source release to be deployed to > > dist.apache.org > > >>>> [2], which are signed with the key with fingerprint B78A5EA1 [3], > > >>>> * all artifacts to be deployed to the Maven Central Repository [4], > > >>>> * source code tag v5.1.0-rc1 [5], > > >>>> * website pull request listing the new release [6]. > > >>>> * CI build of the tag [7]. > > >>>> > > >>>> The vote will be open for at least 72 hours. It is adopted by majority > > >>>> approval, with at least 3 PMC affirmative votes. > > >>>> > > >>>> Thanks, > > >>>> Daren & Keith (Special thanks to Hong and Danny for assisting with the > > >>>> release) > > >>>> > > >>>> [1] > > >>>> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12355281 > > >>>> [2] > > >>>> > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-aws-5.1.0-rc1/ > > >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > >>>> [4] > > >>>> > > https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-aws/5.1.0-1.20/ > > >>>> [5] > > https://github.com/apache/flink-connector-aws/releases/tag/v5.1.0-rc1 > > >>>> [6] https://github.com/apache/flink-web/pull/792 > > >>>> [7] > > >>>> > > https://github.com/apache/flink-connector-aws/actions/runs/15923670284 > > >>>> [8] Discussion thread: > > >>>> https://lists.apache.org/thread/dd0c5pkr7x1t13rcn2gh55gmpq8ysnv0 > > >>> > > >>> > > > > > > > > -- Confidentiality note: This e-mail may contain confidential information from Nu Holdings Ltd and/or its affiliates. If you have received it by mistake, please let us know by e-mail reply and delete it from your system; you may not copy this message or disclose its contents to anyone; for details about what personal information we collect and why, please refer to our privacy policy <https://nubank.com.br/contrato/politica-privacidade/>.
