Hi!

In general I am not a big fan of these blanket overrides of entire
implementations of the autoscaler logic for instance. The main problem I
see is that it does not promote a nice modular and pluggable design but
instead just makes it easier to create effective forks of the codebase
without having to rebuild the operator. If the entire autoscaler logic must
be replaced for a custom functionality then you may as well build a custom
operator image in my view.

I would focus instead on making different parts of the autoscaler logic
more extensible in an easy way and actually contribute those extensions to
the community for everyone to use easily.
One example of such an effort is this flip:
https://cwiki.apache.org/confluence/display/FLINK/FLIP-514%3A+Custom+Evaluator+plugin+for+Flink+Autoscaler

In your case I think we should consider instead introducing a plugin/hook
for the scalingrealizer if that's the use-case we are targeting.

Cheers
Gyula

On Sun, Aug 24, 2025 at 3:03 PM Diljeet Singh
<ctrlaltd...@icloud.com.invalid> wrote:

> Hi,
>
>
> I am looking to do some customizations when flink kubernetes autoscaling
> operations are about to happen, for example I need to apply some Blue/Green
> operations are complete before parallelism update. For me to provide this
> ability presently, I would need to stand up a standalone autoscaler with my
> customizations.
>
> Rather than maintain an additional deployment, I would like the ability to
> provide a customized autoscaler implementation. Currently the
> AutoscalerFactory is set to use the built in JobAutoScalerImpl and this
> behavior cannot be overridden. I would like to propose using Java SPI to
> provide a mechanism to override this default behavior.
>
> Ref:
>
>
> https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/AutoscalerFactory.java#L34
>
>
> https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/AutoscalerFactory.java#L44
>
>
> Happy to contribute and make this change
>
> Best,
> Diljeet(DJ) Singh
>
>
>

Reply via email to