Hi, Sergey & Mate. Thanks for reminding me. I will use a new key and raise a new RC2 after this PR is merged.
Best, Hang On Wed, Nov 26, 2025 at 12:52 PM Mate Czagany <[email protected]> wrote: > > Hi all, > > Thank you Hang for making this release happen! > > I agree with Sergey, 'flink-model-openai' is missing a license in its > NOTICE file, which should have been fixed in my previous PR [1], but I > mistakenly added the jtokkit dependency under "Apache 2.0 License", when in > fact it has an MIT license. I have created another PR [2] and a backport PR > [3] to fix this, I think this also needs to be cherry-picked into this > release. > > Best regards, > Mate > > [1] https://github.com/apache/flink/pull/27261 > [2] https://github.com/apache/flink/pull/27274 > [3] https://github.com/apache/flink/pull/27275 > > On Tue, Nov 25, 2025 at 10:37 PM Sergey Nuyanzin <[email protected]> > wrote: > > > Hi Hang, > > > > thanks for driving the release > > > > I have 2 findings (not sure if they are blockers or not however from > > my point of view very likely): > > > > 1. There was an issue with LicenseChecker [1] which is now fixed both > > in master and release-2.2 branch (however not in this RC) > > Also as as result there was at least one license issue with > > com.knuddels:jtokkit:1.1.0 in flink-model-openai module (fixed within > > same jira issue) > > > > 2. I noticed that RC was signed with key which is not RSA and doesn't > > follow signing release page from Apache [2] > > where it is written > > > All new RSA keys generated should be at least 4096 bits. Do not generate > > new DSA keys. > > > > Please correct me if I'm wrong > > > > [1] https://issues.apache.org/jira/browse/FLINK-38711 > > [2] https://infra.apache.org/release-signing.html#note > > > > On Tue, Nov 25, 2025 at 9:12 AM Hang Ruan <[email protected]> wrote: > > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #1 for the version > > > 2.2.0, as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * JIRA release notes [1], > > > * the official Apache source release and binary convenience releases > > > to be deployed to dist.apache.org [2], which are signed with the key > > > with fingerprint BAF7F56F454D3FE7 [3], > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > * source code tag "release-2.2.0-rc1" [5], > > > * website pull request listing the new release and adding announcement > > > blog post [6], > > > * flink pull request adding release note for users [7]. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Hang > > > > > > [1] > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12356034 > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-2.2.0-rc1/ > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > [4] > > https://repository.apache.org/content/repositories/orgapacheflink-1871/ > > > [5] https://github.com/apache/flink/tree/release-2.2.0-rc1 > > > [6] https://github.com/apache/flink-web/pull/817 > > > [7] https://github.com/apache/flink/pull/27235 > > > > > > > > -- > > Best regards, > > Sergey > >
