Happy New Year to you, too. I have nothing major to add here. Just a few
minor things:
- The link to the sketch (section "The Web UI and REST interfaces") could
be removed. We should add any missing screenshots to the FLIP and not rely
on external resources.
- Maybe, add to the "Rescale Overview UI" section that the goal is to have
the rescale overview aligned with the checkpoint overview
- For the /jobs/:jobid/rescales endpoint, splitting it up into three
endpoints /jobs/:jobid/rescales/{summary,history,overview} might be a good
idea. For /config, we do it like that. But I also see the point of keeping
it as you proposed because we said we want to be close to what the
checkpoint REST endpoint and UI provides. Your call - you can list the
option that you didn't go for under "Rejected Alternatives" to give more
context around the goal that we wanted to keep the Rescale UI/REST API
close to what is available for checkpoints.
- Under "Rescale Details UI" you added a sentence (below the screenshot)
that feels like it should be fixed: "he items need todo keep same as
mentioned Rescale Overview UI"
- You can add a self-explanatory description for "Compatibility,
Deprecation, and Migration Plan" (e.g. No previous work needs to be
considered)
- Test Plan: REST endpoints will be tested with the RestHandler framework.
The UI will be tested visually through manual testing, I guess.
Best,
Matthias
On Fri, Jan 2, 2026 at 12:27 PM Yuepeng Pan (Jira) <[email protected]> wrote:
>
> [
> https://issues.apache.org/jira/browse/FLINK-38853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Yuepeng Pan updated FLINK-38853:
> --------------------------------
> Description:
> As discussed in [
> https://lists.apache.org/thread/w3lrn399vfxy1hhpoc1jgtgqlnr3w1p4.]
>
> > the JSON formatting is not specified in the coding guidelines. That's
> why it comes with no
>
> > surprise that these formatting inconsistencies exist. We would need to
> start a discussion
>
> > on updating the Flink coding guidelines first. Only afterwards, we could
> fix the formatting.
>
> > Such a change would need to be rolled out as part of a major version
> (e.g. 3.0) only, though.
>
> was:
> As discussed in [
> https://lists.apache.org/thread/w3lrn399vfxy1hhpoc1jgtgqlnr3w1p4.]
>
>
> > the JSON formatting is not specified in the coding guidelines. That's
> why it comes with no
>
> > surprise that these formatting inconsistencies exist. We would need to
> start a discussion
>
> > on updating the Flink coding guidelines first. Only afterwards, we could
> fix the formatting. > Such a change would need to be rolled out as part of
> a major version (e.g. 3.0) only, though.
>
>
> > Umbrella: FLIP-XXX: Enhance the standardization of the REST API JSON
> schema
> >
> ---------------------------------------------------------------------------
> >
> > Key: FLINK-38853
> > URL: https://issues.apache.org/jira/browse/FLINK-38853
> > Project: Flink
> > Issue Type: Improvement
> > Components: Runtime / REST
> > Reporter: Yuepeng Pan
> > Priority: Minor
> > Fix For: 3.0.0
> >
> >
> > As discussed in [
> https://lists.apache.org/thread/w3lrn399vfxy1hhpoc1jgtgqlnr3w1p4.]
> > > the JSON formatting is not specified in the coding guidelines. That's
> why it comes with no
> > > surprise that these formatting inconsistencies exist. We would need to
> start a discussion
> > > on updating the Flink coding guidelines first. Only afterwards, we
> could fix the formatting.
> > > Such a change would need to be rolled out as part of a major version
> (e.g. 3.0) only, though.
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.20.10#820010)
>
