Hi Mate,

Thanks for the thorough review! I think this should definitely be fixed.

Although I'm not sure why the job is not failing, since currently the
flink-connector-parent uses maven-shade-plugin 3.2.4 [1], which is not
overridden downstream in the AWS connector repo.

Anyways, fixing the NOTICE files is out of questions, so I'll prepare
another RC, and close this vote.

Thanks,
Ferenc

[1] 
https://github.com/apache/flink-connector-shared-utils/blob/449ed9dea20bc7ec09210ed731c4a0e5b4d9e347/pom.xml#L870


On Sunday, January 25th, 2026 at 16:35, Mate Czagany <[email protected]> wrote:

>
>
> Hi Ferenc,
>
> Thank you for driving the release, but if I'm not mistaken, the NOTICE
> files [1] still reference an old version of AWS SDK, 2.26.19, even though
> in the pom.xml file it's 2.40.3 [2].
>
> In the CI job [3], LicenseChecker thinks that no external packages were
> included in the final jar, so it won't fail the job. It's caused by a
> change in the maven-shade-plugin 3.6.1, and it was solved in the main Flink
> repository under the task FLINK-38711 [4]. In the flink-shaded repository
> it was solved by pinning the version of the plugin to 3.6.0.
>
> Best regards,
> Mate
>
> [1]
> https://github.com/apache/flink-connector-aws/blob/v6.0.0-rc2/flink-connector-aws/flink-sql-connector-aws-kinesis-streams/src/main/resources/META-INF/NOTICE
> [2]
> https://github.com/apache/flink-connector-aws/blob/133acec06bf3e6843b85009e872fad577c66c724/pom.xml#L56
> [3]
> https://github.com/apache/flink-connector-aws/actions/runs/21260681626/job/61193376062
> [4] https://issues.apache.org/jira/browse/FLINK-38711
>
> On Fri, Jan 23, 2026 at 4:49 AM abhi Gupta [email protected] wrote:
>
> > +1 (non-binding)
> >
> > - Verified signatures and hashes as per:
> > https://www.apache.org/info/verification.html
> > - Verified that the source archives do not contain any binaries
> > - Built the source with maven to ensure all source files have apache
> > headers
> > - Checked all POM files have the same version (6.0.0)
> > - Read the README.md file to ensure there is nothing unexpected
> >
> > On 2026/01/22 20:27:49 Ferenc Csaky wrote:
> >
> > > Hi everyone,
> > >
> > > Please review and vote on release candidate #2 for flink-connector-aws
> > > v6.0.0, as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release to be deployed to dist.apache.org
> > > [2], which are signed with the key with fingerprint 16AE0DDBBB2F380B [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag v6.0.0-rc2 [5],
> > > * website pull request listing the new release [6].
> > > * CI build of the tag [7].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Ferenc
> > >
> > > [1] https://issues.apache.org/jira/projects/FLINK/versions/12355986
> > > [2]
> > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-aws-6.0.0-rc2
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4]
> > > https://repository.apache.org/content/repositories/orgapacheflink-1879
> > > [5]
> > > https://github.com/apache/flink-connector-aws/releases/tag/v6.0.0-rc2
> > > [6] https://github.com/apache/flink-web/pull/822
> > > [7]
> > > https://github.com/apache/flink-connector-aws/actions/runs/21260681626

Reply via email to