Hi all, I'd like to follow up on this thread. Since the last discussion in February, the two blockers mentioned by Yuepeng have seen progress:
- CI stabilization (PR #186) — merged on Feb 24 ✅ - FLINK-38851 (PR #183, JDBC Catalog refactoring) — merged on Mar 4 ✅ I've rebased my PR on the latest main to incorporate the FLINK-38851 changes and resolved all compatibility issues: https://github.com/apache/flink-connector-jdbc/pull/156 The PR adds Google Cloud Spanner dialect and catalog support, including: - Spanner dialect implementation - Catalog with schema/table discovery via Spanner Admin API - Array type write support - Query parameter support in JDBC Catalog base-url Would anyone be available to take a look? Any feedback is welcome. Best regards, Tomoyuki NAKAMURA 2026年2月3日(火) 17:05 Tomoyuki NAKAMURA <[email protected]>: > Hi Yuepeng, > > Thank you for the detailed explanation. I appreciate you taking the time > to clarify the current status and the roadmap. > > I understand the situation - it makes sense to wait for the CI fixes > (#186) and lineage adjustments (#180) before proceeding with large-scale > PRs like Spanner support. > > I'll keep an eye on these issues and adjust my PR accordingly once the > groundwork is complete. > > Best regards, > Tomoyuki NAKAMURA > > 2026年2月3日(火) 12:34 Yuepeng Pan <[email protected]>: > >> Hi, Tomoyuki NAKAMURA. >> >> Thank you very much for your attention and contributions. >> >> Please let me share an update on the recent status of the >> flink-connector-jdbc >> in my limited understand: >> >> Currently, the flink-connector-jdbc repository remains under active >> maintenance. >> However, there are some ongoing issues, which is why the community has not >> rushed >> to merge or push forward with certain pull requests. >> These pending PRs can generally be categorized into two types: >> >> - Basic, small-scoped bug fixes or parameter adaptations. >> - Large-scale PRs, such as new Dialect support and refactoring efforts >> aimed >> at better adapting components to the connector framework's features. >> >> There are roughly two main reasons why the review >> of subsequent merge requests has not been expedited: >> >> a: The CI pipeline for the repository has encountered issues[1]. >> This prevents reviewers from obtaining expected results from existing test >> cases. >> Relying solely on manual inspection of a PR’s logic inevitably increases >> the risk of oversight. >> Therefore, the community is actively working to fix the CI issues, >> which is one of the main reasons why even Approved PRs have not been >> merged >> yet. >> >> b: To better adapt to the lineage interface, >> Joao is actively adjusting relevant classes and internal interfaces[2] in >> the repository. >> This will affect other large-scale PRs, potentially leading to significant >> code conflicts. >> If these PRs were reviewed prematurely, both contributors >> and reviewers would end up mired in rework. >> This is the primary reason why progress on major PRs has been temporarily >> paused. >> >> So, once the CI issue[1] is resolved, the community will resume merging >> Approved PRs. >> After Issue [2] is addressed, we will proceed with reviewing those >> large-scale PRs. >> >> We would also warmly welcome your involvement in discussions around >> fixing the CI pipeline if you are interested in it. >> >> Of course, you may decide whether to make proactive adjustments to your PR >> based on this context. >> >> Thank you for your hard work and patience. >> >> [1] https://github.com/apache/flink-connector-jdbc/pull/186 >> [2] https://github.com/apache/flink-connector-jdbc/pull/180 >> >> Best regards, >> Yuepeng Pan >> >> Tomoyuki NAKAMURA <[email protected]> 于2026年2月3日周二 10:48写道： >> >> > Hi, >> > >> > I'd like to request a review for my PR that adds Google Cloud Spanner >> > support to flink-connector-jdbc. >> > >> > JIRA: https://issues.apache.org/jira/browse/FLINK-37288 >> > PR: https://github.com/apache/flink-connector-jdbc/pull/156 >> > >> > The PR includes: >> > - Spanner dialect and catalog implementation >> > - Array type write support >> > - Query parameters support in JDBC Catalog base-url >> > >> > I received some initial review feedback and addressed it, but haven't >> heard >> > back since. >> > >> > Any review would be appreciated. >> > >> > Thanks, >> > -- >> > Tomoyuki NAKAMURA <[email protected]> >> > >> > > > -- > Tomoyuki NAKAMURA <[email protected]> > -- Tomoyuki NAKAMURA <[email protected]>
