Dale Lane created FLINK-41002:
---------------------------------

             Summary: Move test-only defaults out of MiniClusterConfiguration
                 Key: FLINK-41002
                 URL: https://issues.apache.org/jira/browse/FLINK-41002
             Project: Flink
          Issue Type: Improvement
          Components: Runtime / Coordination, Tests
            Reporter: Dale Lane


{{MiniClusterConfiguration#generateConfiguration}} sets two defaults that were 
added to harden tests: * {{pekko.ask.timeout}} = 5 min (FLINK-23906, "to harden 
tests on slow CI")
 * {{cluster.io-pool.size}} = 4 (FLINK-23093)



These apply to every MiniCluster, including non-test uses: the MiniCluster 
application entrypoint (FLINK-40860) has to override them back to the 
distributed defaults, and local execution via {{PerJobMiniClusterFactory}} gets 
them too.

Proposal: set them in test utilities ({{{}MiniClusterExtension{}}} / 
{{MiniClusterWithClientResource}} / {{{}TestingMiniCluster…{}}}) instead, 
deciding separately whether local execution should keep them.
 
Once done, remove the overrides in 
{{MiniClusterJobEntryPoint#buildMiniClusterConfiguration}} (and perhaps the
ITCase {{usesDistributedDefaultsInsteadOfMiniClusterTestDefaults}} /
{{keepsConfiguredAskTimeoutAndIoPoolSize}} checks that cover them)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to