Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/19#discussion_r13845277
--- Diff:
stratosphere-runtime/src/main/java/eu/stratosphere/runtime/io/network/ChannelManager.java
---
@@ -99,8 +95,13 @@ public ChannelManager(ChannelLookupProtocol
channelLookupService, InstanceConnec
this.discardBufferPool = new DiscardBufferPool();
}
- public void shutdown() {
- this.nettyConnectionManager.shutdown();
+ public void shutdown() {
+ try {
+ this.networkConnectionManager.shutdown();
+ } catch (IOException e) {
+ LOG.warn("NetworkConnectionManager did not shutdown
properly.");
--- End diff --
I think we should log the exception as well here (I guess the error is
unlikely and needs review by the user)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
