Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/44#discussion_r14194380
--- Diff:
stratosphere-java/src/test/java/eu/stratosphere/api/java/tuple/Tuple2Test.java
---
@@ -0,0 +1,55 @@
+/***********************************************************************************************************************
+ *
+ * Copyright (C) 2010-2013 by the Stratosphere project
(http://stratosphere.eu)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may
not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on
+ * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
express or implied. See the License for the
+ * specific language governing permissions and limitations under the
License.
+ *
+
**********************************************************************************************************************/
+
+package eu.stratosphere.api.java.tuple;
+
+import junit.framework.Assert;
+
+import org.junit.Before;
+import org.junit.Test;
+
+public class Tuple2Test {
+
+ private Tuple2<String, Integer> classUnderTestTuple2;
+
+ @Before
+ public void setUp() throws Exception {
+ classUnderTestTuple2 = new Tuple2<String, Integer>(new
String("Test case"), 25);
--- End diff --
I would suggest to just move this tuple to the `testSwapValues()` method
since you only use it there. I also think the name is rather verbose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
