Thanks for the update Robert. This needs some review so let's wait merging to master or any branch
On Sunday, July 13, 2014, Robert Metzger <rmetz...@apache.org> wrote: > Regarding the dependencies, I found that they require "jblas", with this > license: https://github.com/mikiobraun/jblas/blob/master/COPYING > It seems to be a BSD license, which is compatible with ASF projects [1]. > > The connectors package depends on RabbitMQ, which is MPL Licensed: > http://www.rabbitmq.com/mpl.html. > We are able to include this into our dependencies, if we label them > appropriately (I guess that means adding a notice to the NOTICE file). > > It also contains ZeroMQ, which is LGPL licensed and we cannot include! > > Apache Kafka is not a problem ;) > > > Another issue that I found is that the streaming project does currently not > have our checkstyle rules enforced (I saw star-imports). It would be cool > if you could fix that as well. > > [1] http://www.apache.org/legal/resolved.html > > > > On Sun, Jul 13, 2014 at 5:41 PM, Márton Balassi <balassi.mar...@gmail.com > <javascript:;>> > wrote: > > > Thanks for the effort. Sorry for the mess, I'll clean it up as soon as > > possible. > > > > Cheers, > > > > Marton > > > > > > On Sun, Jul 13, 2014 at 5:25 PM, Stephan Ewen <se...@apache.org > <javascript:;>> wrote: > > > > > Hi everyone! > > > > > > I have found a way to add the code into the main repository in a > > different > > > branch, preserving all history. > > > All code is rewritten (with history) to be in > > > "flink-addons/flink-streaming" and the commits are prefixed with > > > [streaming]. > > > https://github.com/StephanEwen/incubator-flink/commits/streaming > > > > > > What we can now do is rebase the branch on top of master and then just > > add > > > the commits. > > > > > > For that, I would like to ask for your help: > > > > > > The commit history is a bit messy, to be honest. A lot of stuff is in > > > multiple commits with identical messages. Some commits are called > > > "whatever". Can you clean up the commit history a bit by doing a "git > > > rebase -i 3b88e30924268799c96317fe1bf9f5b9c6bf6f80" and squash some > > commits. > > > > > > I think then we are good to do a merge. > > > > > > Greetings, > > > Stephan > > > > > > > > >
