Cool! Thanks guys - Henry
On Wed, Aug 20, 2014 at 4:17 AM, Stephan Ewen <[email protected]> wrote: > Sorry, my fault. Yes, I skipped CI, because no code was changed. > > But I forgot to add the new DEPENDENCIES file to the checkstyle ignore list. > > Thanks, Robert, for fixing this... > > > On Wed, Aug 20, 2014 at 9:27 AM, Robert Metzger <[email protected]> wrote: > >> In theory, yes, but Stephan added the following string into the commit >> message "[ci skip]": >> >> https://github.com/apache/incubator-flink/commit/8bc7894fe5583176a2b35163980fb45657c80bed >> . >> It tells Travis not to start a build. >> We usually do this for non-code changes (like updating some legal files ;) >> ). >> >> >> On Wed, Aug 20, 2014 at 9:22 AM, Henry Saputra <[email protected]> >> wrote: >> >> > Thanks Robert. >> > >> > Hmm, shouldn't Flink travis CI barf too? >> > >> > - Henry >> > >> > On Tue, Aug 19, 2014 at 11:54 PM, Robert Metzger <[email protected]> >> > wrote: >> > > Hi, >> > > >> > > I think rat is being executed when doing an "install" or "verify" (its >> > > bound to the "verify" phase). We have it this way so that our CI finds >> > pull >> > > requests with wrong license headers (happens often to new >> contributors). >> > > >> > > But you are right, the "DEPENDENCIES" file Stephan committed yesterday >> is >> > > marked as unapproved by apache-rat. I'll commit a fix ... >> > > >> > > >> > > Robert >> > > >> > > >> > > On Wed, Aug 20, 2014 at 7:48 AM, Henry Saputra < >> [email protected]> >> > > wrote: >> > > >> > >> Hi guys, >> > >> >> > >> I just pulled from master and when tried to do mvn install I got >> error: >> > >> >> > >> [ERROR] Failed to execute goal >> > >> org.apache.rat:apache-rat-plugin:0.10:check (default) on project >> > >> flink-parent: Too many files with unapproved license: 1 See RAT report >> > >> in: /home/hsaputra/open/hsaputra/incubator-flink/target/rat.txt -> >> > >> [Help 1] >> > >> >> > >> Are we enabling RAT check on mvn install flow now? >> > >> >> > >> - Henry >> > >> >> > >>
