Hi! Thanks for the patch on the streaming connector dependencies. Here are a few thoughts:
- Problems occur mainly when newer versions are incompatible with older versions, but overlap in the namespace. Unfortunately, that happened with guava. - As a consequence: The exclusions on commons-cli, -codec, -config, ... may not actually be needed. They are anyways used by our system. If we do an entry in "dependency management" in the root pom, we can make sure the correct (highest) version gets bundled, and all should be fine. - I see that some connectors need netty in a 3.x version, while the flink runtime needs netty 4.x. The 4.x netty classes I have looked at are named different than the 3.x classes, but I am not sure that holds for all classes. It might be a good idea to start shading netty in the core as well. I hope we finally figured out how to do this correctly ;-) - In general, it may make sense to build one fat "streaming-connectors" jar, that contains the flink-streaming-connectors code plus shaded versions of all potentially conflicting dependencies (guava, netty, joda time, zookeeper, ...) What do you think? Stephan
