@Stephan - sure I could work on it. Been wanting to do it for a while. No, it is not the checkstyle issue.
- Henry On Mon, Jan 5, 2015 at 1:16 AM, Stephan Ewen <se...@apache.org> wrote: > Yes, the "hadoopcompatibility" is a bit long, I agree to change it to > "hadoop". > > Henry, do you want to do this? > > But the reason is not checkstyle here, is it? > > On Mon, Jan 5, 2015 at 9:27 AM, Henry Saputra <henry.sapu...@gmail.com> > wrote: > >> Yeah, automated tools can only do so much. >> I always turn off the automatic line wrapping since it cant tell for >> imports and regular code. >> >> And BTW I think we need to shorten some of Flink package and class names. >> For example, hadoopcompatibility can just be changed to hadoop package. >> >> - Henry >> >> On Sun, Jan 4, 2015 at 11:33 PM, Till Rohrmann <trohrm...@apache.org> >> wrote: >> > I just checked and in fact this option is already turned on. The problem >> > was that I activated automatic line wrapping if a line is longer than 100 >> > characters in order to comply with the scalastyle plugin. Since Intellij >> > cannot distinguish between Imports and code it also wrapped the import >> > statements. I guess then the only viable option is to manually wrap the >> > lines. >> > >> > On Sun, Jan 4, 2015 at 10:34 PM, Stephan Ewen <se...@apache.org> wrote: >> > >> >> Excluding the imports sounds like a good idea. >> >> >> >> On Sun, Jan 4, 2015 at 10:30 PM, Henry Saputra <henry.sapu...@gmail.com >> > >> >> wrote: >> >> >> >> > I think we could add exclude for imports statements line length >> checking. >> >> > >> >> > Without limit of line length we need to be very careful when coding >> long >> >> > lines to keep the code easy to read and understand, hence the line >> >> > length style safe guard. >> >> > Some if the java code has very long lines that make it hard to read. >> >> > >> >> > On Sunday, January 4, 2015, Stephan Ewen <se...@apache.org> wrote: >> >> > >> >> > > Hi all! >> >> > > >> >> > > I would suggest to remove the line length limitation in the >> scala-style >> >> > > definition. >> >> > > >> >> > > It leads to very awkward formattings (see for example TaskManager >> >> > imports) >> >> > > and at >> >> > > this point I am not sure it helps us in any way. >> >> > > >> >> > > Greetings, >> >> > > Stephan >> >> > > >> >> > >> >> >>
