----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5880/#review9024 -----------------------------------------------------------
lgtm. One item, we call this kind of configuration "batchSize" most places correct? - Brock Noland On July 10, 2012, 9:56 a.m., Juhani Connolly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5880/ > ----------------------------------------------------------- > > (Updated July 10, 2012, 9:56 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added a new configuration setting "bufferCount" to allow for multiple lines > read from the exec output to be committed in a single channel transaction > > > This addresses bug FLUME-1361. > https://issues.apache.org/jira/browse/FLUME-1361 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java dbf79e0 > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java > 73c985e > > Diff: https://reviews.apache.org/r/5880/diff/ > > > Testing > ------- > > Unit tests pass though new ones were not added. > > Further, tested this on our log generating servers and it alleviated the > incredibly poor performance of file channel caused by the constant commits > coming from ExecSource > > > Thanks, > > Juhani Connolly > >
