----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5906/ -----------------------------------------------------------
Review request for Flume. Description ------- Added port failover as with other channels. I also made the source throw a FlumeException on failure to start. Perhaps this is too harsh, and I can remove it/test if the source has correctly started instead. Also moved super.start/stop() to the end of their respective functions, as the lifecycle state shouldn't be updated until the source is actually started/stopped Diffs ----- flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java c195db7 Diff: https://reviews.apache.org/r/5906/diff/ Testing ------- Updated test confirmed working Thanks, Juhani Connolly
