> On July 12, 2012, 10:51 a.m., Jarek Cecho wrote: > > Hi Juhani, > > your changes looks good to me. Could you please attach your patch to the > > JIRA? > > > > Jarcec
Done! - Juhani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5905/#review9102 ----------------------------------------------------------- On July 11, 2012, 8:30 a.m., Juhani Connolly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5905/ > ----------------------------------------------------------- > > (Updated July 11, 2012, 8:30 a.m.) > > > Review request for Flume. > > > Description > ------- > > The loop that fails over to different ports to bind to depends on a > ChannelException to happen, and the start() of the legacy source simply > ignores bind exceptions. > > I fix this by wrapping the TTransportException with a FlumeException and > looking for that in the test. > > An alternative approach would be to check if the source started correctly, > and I'd be happy to change it to this if it seemed preferable > > > This addresses bug FLUME-1362. > https://issues.apache.org/jira/browse/FLUME-1362 > > > Diffs > ----- > > > flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java > 5b056fc > > flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java > 4869665 > > Diff: https://reviews.apache.org/r/5905/diff/ > > > Testing > ------- > > Verified the updated tests work as expected > > > Thanks, > > Juhani Connolly > >
