> On July 17, 2012, 7:55 a.m., Mike Percy wrote: > > lgtm. Only thing - can we add a unit test for this functionality? > > Hari Shreedharan wrote: > Thanks for the review, Mike. > > Ganglia uses a binary protocol as you can see to transmit the data. I > could not find a Ganglia server unit test framework, the only way we could > add one is to consider the same protocol used to send. For now, I filed: > https://issues.apache.org/jira/browse/FLUME-1375 to track this. If I can find > a way to add these tests, will add it later if you don't mind. > > Thanks.
That's fine. Unit tests pass. +1 - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6009/#review9209 ----------------------------------------------------------- On July 17, 2012, 7:45 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6009/ > ----------------------------------------------------------- > > (Updated July 17, 2012, 7:45 a.m.) > > > Review request for Flume. > > > Description > ------- > > Support reporting to Ganglia. > > > This addresses bug FLUME-1374. > https://issues.apache.org/jira/browse/FLUME-1374 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitorService.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoringType.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst 40fd59c > > flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java > fe20f13 > > Diff: https://reviews.apache.org/r/6009/diff/ > > > Testing > ------- > > Tested against a Ganglia metanode. > > > Thanks, > > Hari Shreedharan > >
