----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6089/#review9567 -----------------------------------------------------------
Denny, Thanks for the patch. I have a couple of general comments before I do a full review: a) The scribe source should not be in the legacy sources sub-module. It should be under a new submodule called flume-ng-sources (take a look at how flume-ng-sinks contains the HDFS and HBase sinks). Legacy sources submodule is meant to support sources which allow transfer of data between Flume OG(0.9x) and Flume NG(1.x). b) Please remove trailing whitespaces and use 2-spaces for indentation. Please do not use tabs, Reviewboard highlights them in red. Eclipse and Netbeans can do this for you automatically. It would be great if you could update the documentation too - explaining how the source can be used. - Hari Shreedharan On July 23, 2012, 6:38 a.m., Denny Ye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6089/ > ----------------------------------------------------------- > > (Updated July 23, 2012, 6:38 a.m.) > > > Review request for Flume and Hari Shreedharan. > > > Description > ------- > > There may someone like me that want to replace central Scribe with Flume to > adopt existing ingest system, using smooth changes for application user. > Here is the ScribeSource put into legacy folder without deserializing. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1382. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1382 > > > Diffs > ----- > > trunk/flume-ng-dist/pom.xml 1364507 > trunk/flume-ng-legacy-sources/flume-scribe-source/pom.xml PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/LogEntry.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ResultCode.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/Scribe.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ScribeSource.java > PRE-CREATION > trunk/flume-ng-legacy-sources/pom.xml 1364507 > trunk/pom.xml 1364507 > > Diff: https://reviews.apache.org/r/6089/diff/ > > > Testing > ------- > > I already used ScribeSource into local environment and tested in past week. > It can use the existing local Scribe interface > > > Thanks, > > Denny Ye > >
