> On July 30, 2012, 2:35 a.m., Brock Noland wrote: > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java, > > line 184 > > <https://reviews.apache.org/r/6183/diff/3/?file=130184#file130184line184> > > > > If this is an Error or RuntimeException I think we should re-throw.
Agreed. Will update the patch. > On July 30, 2012, 2:35 a.m., Brock Noland wrote: > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java, > > line 201 > > <https://reviews.apache.org/r/6183/diff/3/?file=130184#file130184line201> > > > > Any reason we are using an exception to log this timeout message? > > > > Also, we have combined the interrupt and timeout into one log message. Yes, you are right. I have modified this to simply set txnFail if condition.await returns false, and the failure processing code should take care of it. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6183/#review9580 ----------------------------------------------------------- On July 28, 2012, 7:19 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6183/ > ----------------------------------------------------------- > > (Updated July 28, 2012, 7:19 p.m.) > > > Review request for Flume. > > > Description > ------- > > Timeout the sink if all callbacks are not received within the configurable > timeout. > > > This addresses bug FLUME-1401. > https://issues.apache.org/jira/browse/FLUME-1401 > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst 56011e8 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java > 6df1f33 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java > a16cda8 > > Diff: https://reviews.apache.org/r/6183/diff/ > > > Testing > ------- > > All unit tests pass. Did functional testing. > > > Thanks, > > Hari Shreedharan > >
