----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6086/#review9627 -----------------------------------------------------------
Ship it! Ship It! - Hari Shreedharan On July 23, 2012, 3:24 a.m., Patrick Wendell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6086/ > ----------------------------------------------------------- > > (Updated July 23, 2012, 3:24 a.m.) > > > Review request for Flume. > > > Description > ------- > > This checks for an unspecified interceptor type and returns a clear > exception. Prior to this patch, an NPE is thrown if an interceptor is not > specified. > > I'm not sure if this is the right place to do this type of validation or if > interceptors should be included in the existing validation framework somehow. > > > This addresses bug FLUME-1389. > https://issues.apache.org/jira/browse/FLUME-1389 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java > 53bfac1 > > Diff: https://reviews.apache.org/r/6086/diff/ > > > Testing > ------- > > I re-built flume and tested with a bad config and ensure the error was thrown. > > > Thanks, > > Patrick Wendell > >
