> On Aug. 7, 2012, 1:38 a.m., Juhani Connolly wrote: > > It looks like the license issues aren't a problem. > > > > Do you think you could add some basic documentation: explaining intended > > use, configuration, and possibly providing a *.thrift file for code > > generation, or directions for downloading the scribe.thrift file(so people > > can build clients) would be good.
Yes, please include the .thrift file and instructions for regenerating the checked-in code. Also, as Hari asked, please create a new submodule for this source instead of re-using flume-legacy-sources sub-module. Should be: flume-ng-sources/flume-scribe-source - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6089/#review9932 ----------------------------------------------------------- On Aug. 6, 2012, 7:53 a.m., Denny Ye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6089/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 7:53 a.m.) > > > Review request for Flume and Hari Shreedharan. > > > Description > ------- > > There may someone like me that want to replace central Scribe with Flume to > adopt existing ingest system, using smooth changes for application user. > Here is the ScribeSource put into legacy folder without deserializing. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1382. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1382 > > > Diffs > ----- > > trunk/flume-ng-dist/pom.xml 1364507 > trunk/flume-ng-legacy-sources/flume-scribe-source/pom.xml PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/LogEntry.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ResultCode.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/Scribe.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ScribeSource.java > PRE-CREATION > trunk/flume-ng-legacy-sources/pom.xml 1364507 > trunk/pom.xml 1364507 > > Diff: https://reviews.apache.org/r/6089/diff/ > > > Testing > ------- > > I already used ScribeSource into local environment and tested in past week. > It can use the existing local Scribe interface > > > Thanks, > > Denny Ye > >
