----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6578/#review10229 -----------------------------------------------------------
Patch looks good in generic. Just two items below. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java <https://reviews.apache.org/r/6578/#comment21662> I am not sure this is a hard requirement but I prefer braces even for on liners. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java <https://reviews.apache.org/r/6578/#comment21663> The HashMap is missing the generics. - Brock Noland On Aug. 13, 2012, 5:47 p.m., Yongcheng Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6578/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2012, 5:47 p.m.) > > > Review request for Flume. > > > Description > ------- > > This resolves Flume-1350 which describes a problem of Flume where HDFS file > handle does not close properly when date bucketing. The fix adds a map > between the sink's path and its real path. Whenever a new real path is > generated due to data bucketing, it closes the bucketwriter associated with > existing real path and update the link between the sink's path and its real > path. > > > This addresses bug Flume-1350. > https://issues.apache.org/jira/browse/Flume-1350 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > fcb9642 > > Diff: https://reviews.apache.org/r/6578/diff/ > > > Testing > ------- > > The fix has been manually tested. > > > Thanks, > > Yongcheng Li > >
