----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6567/#review10240 -----------------------------------------------------------
Ship it! Ship It! - Mubarak Seyed On Aug. 13, 2012, 7:10 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6567/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2012, 7:10 p.m.) > > > Review request for Flume. > > > Description > ------- > > Support for expose metrics by HTTP. Refactored Ganglia metrics to move the > JMX polling code to a util to be reused by JSON server as well. > > > This addresses bug FLUME-1482. > https://issues.apache.org/jira/browse/FLUME-1482 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > cc8f89a > flume-ng-core/pom.xml 8dd0d3e > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > 65b0166 > > flume-ng-core/src/main/java/org/apache/flume/channel/PseudoTxnMemoryChannel.java > 489d3e5 > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/ChannelCounter.java > 316384a > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/ChannelCounterMBean.java > 799dd5d > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java > d93cd33 > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java > a03d004 > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoringType.java > d132995 > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/SinkCounterMBean.java > 6905d49 > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/SourceCounterMBean.java > e6612d5 > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/util/JMXPollUtil.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/instrumentation/util/JMXTestUtils.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/instrumentation/util/TestJMXPollUtil.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst 45dd7cc > pom.xml 8c67610 > > Diff: https://reviews.apache.org/r/6567/diff/ > > > Testing > ------- > > Added unit tests for JSON server and JMX polling code. > > > Thanks, > > Hari Shreedharan > >
