> On Aug. 17, 2012, 6:58 a.m., Denny Ye wrote: > > That's good. If there have limitation about rate and max size of event, > > it's better. > > Will McQueen wrote: > Hi Denny, > > The StressSource currently includes a 'size' prop to set each event's > payload to a fixed size. As for the fixed rate that you and Patrick mention, > I think that would be useful too but could you please open a separate ticket > for that since the current ticket is just focusing on limiting the count of > events? I'd appreciate it. > > Cheers, > Will
Yep, like to keep this review scope-limited to FLUME-1490. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6673/#review10452 ----------------------------------------------------------- On Aug. 17, 2012, 3:39 p.m., Patrick Wendell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6673/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 3:39 p.m.) > > > Review request for Flume. > > > Description > ------- > > This patch implements a count limit, both for overall (successful + failed) > events and for successful events. Seems like both could be useful in testing. > > > This addresses bug FLUME-1490. > https://issues.apache.org/jira/browse/FLUME-1490 > > > Diffs > ----- > > flume-ng-core/pom.xml 8708953 > flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java > 4f7b255 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java > 579b257 > flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6673/diff/ > > > Testing > ------- > > Includes unit test and a bit of code clean-up. > > > Thanks, > > Patrick Wendell > >
