----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6788/#review10795 -----------------------------------------------------------
This looks like a great change. However, there is already a TestUtils class in the FIleChannel package. Maybe that is an appropriate place to move the functions? - Brock Noland On Aug. 27, 2012, 8:42 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6788/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2012, 8:42 p.m.) > > > Review request for Flume. > > > Description > ------- > > Refactor file channel tests. > > > This addresses bug FLUME-1496. > https://issues.apache.org/jira/browse/FLUME-1496 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/FileChannelTestUtils.java > PRE-CREATION > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java > 3e01395 > > Diff: https://reviews.apache.org/r/6788/diff/ > > > Testing > ------- > > Test only change > > > Thanks, > > Hari Shreedharan > >
