> On Aug. 31, 2012, 2:51 p.m., Brock Noland wrote: > > A couple items here, the big one being that ComparableFlumeEventPointer > > doesn't implement hashCode and equals so it cannot be removed from the > > sets. Probably only want to use the ptr itself in those methods.
Ah sorry, in my first implementation - I inherited from FlumeEventPointer, which I forgot to change. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6870/#review10940 ----------------------------------------------------------- On Aug. 31, 2012, 3:50 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6870/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2012, 3:50 p.m.) > > > Review request for Flume and Brock Noland. > > > Description > ------- > > Added a class which loads the events into queue faster at the expense of more > memory. It is configurable. > > > This addresses bug FLUME-1528. > https://issues.apache.org/jira/browse/FLUME-1528 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java > PRE-CREATION > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 995bad5 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java > 9fc8df1 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > b8f6570 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/ReplayHandler.java > 6f8af09 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java > 0fd3176 > > Diff: https://reviews.apache.org/r/6870/diff/ > > > Testing > ------- > > Added 2 unit tests to test this, using the already existing testRestart patch. > > > Thanks, > > Hari Shreedharan > >
