> On Sept. 2, 2012, 8:43 p.m., Will McQueen wrote: > >
I don't think both these are really concerns at all, except from a theoretical perspective. Note that the only reason this class exists is so that we can associate order id with a FlumeEventPointer object. That said, the changes required are not major so I am ok with uploading a new patch. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6892/#review10980 ----------------------------------------------------------- On Sept. 2, 2012, 6:47 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6892/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2012, 6:47 p.m.) > > > Review request for Flume. > > > Description > ------- > > The equals() method in ComparableFlumeEventPointer was not working correctly, > and hence remove() calls from sets were not removing anything. > > > This addresses bug FLUME-1534. > https://issues.apache.org/jira/browse/FLUME-1534 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java > 4db1b9c > > Diff: https://reviews.apache.org/r/6892/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
