----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6942/#review11114 -----------------------------------------------------------
Nice work! Looks good, just a little trailing whitespace on this one as well. - Brock Noland On Sept. 6, 2012, 11:10 a.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6942/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2012, 11:10 a.m.) > > > Review request for Flume. > > > Description > ------- > > This was a message in the lifecycle class that prints out every N ms while > the class is waiting for the state the change. I removed this message > because it fills up the logs and provides little value. > > I also added state information to the fail message that fires if the desired > state is not found before the deadline expires. > > > This addresses bug FLUME-1519. > https://issues.apache.org/jira/browse/FLUME-1519 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleController.java > cc1a712 > > Diff: https://reviews.apache.org/r/6942/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
