----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6949/#review11164 -----------------------------------------------------------
Nice work! A few minor issues below to resolve and then I will commit this! flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java <https://reviews.apache.org/r/6949/#comment23886> Let's keep this private and then use the fast reflection api to get the reference in the test. flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java <https://reviews.apache.org/r/6949/#comment23881> We should keep these as private variables. flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java <https://reviews.apache.org/r/6949/#comment23883> We don't copy the buffer in EventBuilder. As such there is only one "buffer" and we are updating all events with this fill. I'd prefer to keep those semantics as opposed to creating a new buffer for each event. flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java <https://reviews.apache.org/r/6949/#comment23884> This is not needed. flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java <https://reviews.apache.org/r/6949/#comment23882> Instead of referencing the member variable, let's keep them private and then use the fast reflection api (like the method directly above). flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java <https://reviews.apache.org/r/6949/#comment23885> Add the @Test annotation above this method and the extends TestCase is not required. - Brock Noland On Sept. 7, 2012, 1:06 a.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6949/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 1:06 a.m.) > > > Review request for Flume. > > > Description > ------- > > Adding batchSize to StressSource along with junit to test it. > > Important note: the total number of events getting sent will equals > maxTotalEvents, so if maxTotalEvents is not devisable by batchSize then the > last batch will contain only the remainder of events needed to reach > maxTotalEvents. > > > This addresses bug FLUME-1536. > https://issues.apache.org/jira/browse/FLUME-1536 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java > 5b73910 > flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java > 4ec16c7 > > Diff: https://reviews.apache.org/r/6949/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
